Giter Club home page Giter Club logo

Comments (4)

vaitkus avatar vaitkus commented on August 12, 2024

There are not a lot of entries with in the COD with the _atom_type_scat.versus_stol_list item (33 entries out of 500 000, COD revision 282530), but it was already agreed in issue #216 that the definition of this item should be reverted to match the one in the DDL1 dictionary and then potentially deprecated in favour of a separate category. The DDL1 version defined it as a free-form text field and strongly recommended using a formatted list, but other than that did not impose any strict requirements on the items. The new approach that formalises the table is of course preferable, but the old item should be retained for backwards-compatibility and archival purposes.

That being said, I am unsure if the 0.01 increments should be explicitly provided as a requirement rather than a strong recommendation. For example, COD entry 4001518 which uses the DDL1 version of the _atom_type_scat.versus_stol_list contains lists with the increments of 0.05, i.e.:

loop_
_atom_type_symbol
_atom_type_scat_dispersion_real
_atom_type_scat_dispersion_imag
_atom_type_scat_source
_atom_type_scat_versus_stol_list
Pd -0.999 1.007 'International Tables Vol C Tables  4.2.6.8 and 6.1.1.1'
;
 stol     0.00    0.05    0.10    0.15    0.20    0.25    0.30    0.35    0.40  
  f     46.000  45.232  43.172  40.357  37.286  34.283  31.523  29.077  26.961  
 stol     0.45    0.50    0.55    0.60    0.65    0.70    0.75    0.80    0.85  
  f     25.153  23.617  22.307  21.177  20.186  19.296  18.482  17.711  16.979  
 stol     0.90    0.95    1.00    1.05    1.10    1.15    1.20    1.25    1.30  
  f     16.266  15.573  14.893  14.228  13.580  12.950  12.342  11.757  11.200  
 stol     1.35    1.40    1.45    1.50    1.55    1.60    1.65    1.70    1.75  
  f     10.671  10.173   9.705   9.270   8.865   8.492   8.148   7.833   7.545  
;

Should we mark this issue as a duplicate of #216 or do you see this discussion going a different way?

from cif_core.

rowlesmr avatar rowlesmr commented on August 12, 2024

I'll think on how to include a new category. The s-grid in ITC isn't 0.01 either, so, we've got that going for us...

from cif_core.

rowlesmr avatar rowlesmr commented on August 12, 2024

Duplicate of #216

from cif_core.

vaitkus avatar vaitkus commented on August 12, 2024

Closing the issue since it is a duplicate.

from cif_core.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.