Comments (7)
Thanks for the report.
Alternative would be to use https://pypi.python.org/pypi/plone.app.registry/1.5, which supports the condition in the registry.xml. Would that work for you?
from collective.roster.
The standard Plone buildout pins plone.app.registry to 1.2.4, which I guess is too old. Is version 1.5 compatible with Plone 4.3? (I'm guessing no, since plone/plone.app.registry/README.rst says "1.3.x versions are for Plone 5. 1.2.x versions are for Plone 4.")
from collective.roster.
from collective.roster.
It's actually worse than I thought -- you can't even install collective.roster into a Plone 4.3 site:
Traceback (innermost last):
Module ZPublisher.Publish, line 138, in publish
Module ZPublisher.mapply, line 77, in mapply
Module ZPublisher.Publish, line 48, in call_object
Module Products.PloneHotfix20160830.redirect_qi, line 14, in QuickInstallerTool_installProducts
Module Products.CMFQuickInstallerTool.QuickInstallerTool, line 686, in installProducts
Module Products.CMFQuickInstallerTool.QuickInstallerTool, line 603, in installProduct
__traceback_info__: ('collective.roster',)
Module Products.GenericSetup.tool, line 379, in runAllImportStepsFromProfile
__traceback_info__: profile-collective.roster:default
Module Products.GenericSetup.tool, line 1414, in _runImportStepsFromContext
Module Products.GenericSetup.tool, line 1226, in _doRunImportStep
__traceback_info__: plone.app.registry
Module plone.app.registry.exportimport.handler, line 49, in importRegistry
Module plone.app.registry.exportimport.handler, line 94, in importDocument
Module plone.app.registry.exportimport.handler, line 281, in importRecords
Module zope.dottedname.resolve, line 38, in resolve
ImportError: No module named IBundleRegistry
As you can see, the last part of the traceback (and, presumably, the underlying cause) is the same. AIUI, the version of plone.app.registry used in Plone 4.3 doesn't support the condition="have plone-5"
syntax so it tries to import the stuff in profiles/default/registry.xml anyway, right?
If I pin to 4bce0e3 (the last checkout before registry.xml was added), then I am able to install collective.roster once more.
I came across plone/Products.CMFPlone#1406 which seems to indicate that this condition stuff was only recently added (mostly by you), and not yet backported to the 1.2.x branch of plone.app.registry?
from collective.roster.
I backported registry conditions for plone.app.registry 1.2.x. Once those are merged and released, I update setup.py to require at least that version of plone.app.registry. As you said, an alternative fix would be to have different profiles for Plone 4 and Plone 5, but I'd choose the registry fix, because that was supposed to fix this exact compatibility issue.
from collective.roster.
I see that PR was accepted, so I added to my [sources]
section:
plone.app.registry = git https://github.com/plone/plone.app.registry.git branch=1.2.x
and now collective.roster (2.1.2, latest from PyPI) installation works fine, as do the upgrade steps.
Nice work! 👍
from collective.roster.
FYI, plone.app.registry v1.2.5 has been released with that fix, and I have tested that it works.
from collective.roster.
Related Issues (10)
- Enable Travis-CI -integration HOT 1
- simpleterm creation HOT 4
- person title "overkill" HOT 9
- Add support for Python 3
- Add support for Plone 6
- short number not valid HOT 1
- Plone 5.0.6 don't see roster in navigation(main menu) or default view for folder. HOT 2
- Roster objects have absolute path in UID catalog, which causes import error HOT 1
- missing dependency HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from collective.roster.