Giter Club home page Giter Club logo

Comments (4)

TedDriggs avatar TedDriggs commented on August 26, 2024 2

Similar to @faern's comment here on #67, having to write the struct definition manually (and keep all fields and docs in sync) would lose a lot of the value of having the builder. That sort of setter generation could be done without proc macros.

To me, the benefit of proc macros is not just LOC saved, it's time saved keeping names in sync, and time saved reading code because boilerplate isn't presented.

from rust-derive-builder.

TedDriggs avatar TedDriggs commented on August 26, 2024

Maybe this should be a separate derive(...) trait that goes on the handcrafted Builder struct? Something like #[derive(Setter)]? The downside then is that it's weird to have the #[builder(...)] attributes take effect on something that isn't a builder.

from rust-derive-builder.

colin-kiegel avatar colin-kiegel commented on August 26, 2024

Hm, if we put the derive on the builder struct, I'd expect that most, if not all, attributes would require a different interpretation (e.g. skip, name`). This could nearly double our amount of testcases. That would be the main problem with that IMO.

from rust-derive-builder.

TedDriggs avatar TedDriggs commented on August 26, 2024

I don't see this happening; closing the issue to maintain repo hygiene.

from rust-derive-builder.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.