4 failing tests about aiosmtplib HOT 7 CLOSED

Huh, that's odd. The tests use the aiosmtpd package to run an SMTPD server. From the errors it seems like it's not responding, but only when used with login. CI runs on the python 3.9 buster image, so I'm surprised this is different.

from aiosmtplib.

How is the aiosmtpd server started? I'm eager to try having a closer look. :)

In particular, how does the test login/password gets feeded to aiosmtpd to populate the "user database" for the actual test?

from aiosmtplib.

The server is initialized here: https://github.com/cole/aiosmtplib/blob/main/tests/conftest.py#L26. it is used in many test though, not just the failing ones.

Login is hardcoded to test/test here: https://github.com/cole/aiosmtplib/blob/main/tests/smtpd.py#L127

from aiosmtplib.

@cole I found out the issue.

In https://github.com/cole/aiosmtplib/blob/main/tests/smtpd.py#L110, the smtp_AUTH is what receives and is supposed to pass auth with login attempts to smtp_AUTH_LOGIN.

But, in https://github.com/cole/aiosmtplib/blob/main/aiosmtplib/auth.py#L70 you iterate on the diverse auth methods available, and the first picked is "plain" which is not supported by your test smtpd server in a way that makes it not return anything.

This patch fixes the issue:

--- tests/smtpd.py	2021-05-07 20:39:01.075953762 +0000
+++ tests/smtpd.py	2021-05-07 20:35:39.225206826 +0000
@@ -115,6 +115,8 @@
 
         if arg[:5] == "LOGIN":
             await self.smtp_AUTH_LOGIN(arg[6:])
+        else:
+            await self.push("504 Unsupported auth method.")
 
     async def smtp_AUTH_LOGIN(self, arg):
         with open("/tmp/test", "a") as testfile:

I don't know why the issue doesn't occur in your CI runner.

from aiosmtplib.

Yes, thank you. The suggested patch resolved the issue for me (and the openSUSE package).

from aiosmtplib.

Happy to help.

from aiosmtplib.

Released 1.1.6 with the change.

from aiosmtplib.