Convert PackageDescriptor.dependencies into an object so metadata can be attached. about colcon-core HOT 9 CLOSED

I am wondering if it is necessary / useful to update all the packages which don't have any metadata or if we should just close those and let them keep adding plain str dependency names?

from colcon-core.

I think they can be closed for now, and if at some point those packages want to add metadata then that can be done in a PR with the metadata addition.

Do you think the guidance from now on should be to use DependencyDescriptor?
Should consumers of dependencies that need the metadata just always verify the dependency is a DependencyDescriptor?

from colcon-core.

I think they can be closed for now, and if at some point those packages want to add metadata then that can be done in a PR with the metadata addition.

Sounds good to me. Please go ahead and close the ones which don't contain metadata atm (or update them to do so).

Should consumers of dependencies that need the metadata just always verify the dependency is a DependencyDescriptor?

Atm they certainly have to do that before trying to access the metadata attribute.

Do you think the guidance from now on should be to use DependencyDescriptor?

Since code will need to check for the foreseeable future anyway if the entry is a descriptor or a plain str I wouldn't force code to be updated. Maybe in future minor release before reaching 1.0 it would be good to "break" the assumption and require every entry to be a descriptor.

from colcon-core.

Closed all the changes that don't add any metadata. Do you know when you'll cut the next release of colcon-core?

from colcon-core.

We recently changed our bootstrap repo which contains all the Python packages so I am not 100% confident to do it now (with others not available) if something goes wrong. But I will aim to ship a new release of colcon-core on Monday.

from colcon-core.

I am still blocked by problems with our bootstrap repo. I will comment here as soon as I was able to do a release... 😞

from colcon-core.

colcon-core 0.3.10 has just been released. Sorry for the delay. Please update the remaining PRs to include that version dependency - their CI should then pass and be mergable.

from colcon-core.

Also colcon-python-setup-py 0.2.1 and colcon-ros 0.3.5 have been 🚢.

Is there anything else remaining in the scope of this ticket?

from colcon-core.

Awesome, thanks for getting these changes shipped! Everything for this ticket is completed. Will close it.

from colcon-core.