Comments (2)
prajakta-gokhale
commented on August 16, 2024
This test failure is because tarfile.DEFAULT_FORMAT changed from GNU_FORMAT to PAX_FORMAT in Python 3.8.
With this change, the header size (and subsequently offset) of overlays calculated in bundlefile.py changed from 512 bytes in GNU_FORMAT to 1536 bytes in PAX_FORMAT.
For the unit tests to work in both python3.8, we need to account for the extra header size in unit tests.
from colcon-bundle.
prajakta-gokhale
commented on August 16, 2024
There were 2 problems why tests were failing and why the header size was different in different python versions:
- Default format is set to
tarfile.GNU_FORMATinclose(), so all operations performed before (like initialization) had format mismatch. - Format is not passed as a parameter while calculating
headerand thusoffsetsizes.
Fix is in #161.
from colcon-bundle.
Related Issues (20)
- Support Python 3.8 on Xenial / Ubuntu 16 HOT 1
- Review tests ran in workflow HOT 1
- Add tests to run colcon-bundle against APT installed colcon HOT 3
- Patch nodejs scripts like Python and Bash scripts are patched
- Ubuntu 20.04 with Noetic support HOT 1
- package.xml format 3 with condition doesn't work properly. HOT 2
- Support Ubuntu 20.04 Focal Fossa HOT 2
- Could not find key for... after colcon bundle HOT 8
- colcon bundle is intermittently failing to fetch apt packages HOT 2
- Dynamic libraries not found when deploying on ARM64 HOT 1
- colcon bundle command is always pulling the dependencies from internet HOT 4
- Idea: use AppImage as a bundle output format
- Is there colcon bundle provides any way ROS bundle output having non readable binary or something encrypted to prevent steal python source code HOT 1
- Colcon bundle for local packages HOT 1
- Debian files from local apt cache are not properly installed
- failed to colcon bundle HOT 2
- broken symlinks in dependencies HOT 5
- Question - Minimize the footprint of colcon bundle?
- install folder doesnt exist
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from colcon-bundle.