Giter Club home page Giter Club logo

Comments (4)

defrag avatar defrag commented on September 2, 2024

That would be nice, we need to dig some test cased first tho, cuz different ordinalize rules applies to different languages.

from php-humanizer.

doenietzomoeilijk avatar doenietzomoeilijk commented on September 2, 2024

Absolutely. The test cases would have to be international as well. Since there's more logic involved I don't see the localisation files being doable as Yaml.

Eitherway, I could whip up a couple of test cases for English and Dutch later today, would you like me to do that?

from php-humanizer.

norberttech avatar norberttech commented on September 2, 2024

@doenietzomoeilijk yes, please : )

from php-humanizer.

doenietzomoeilijk avatar doenietzomoeilijk commented on September 2, 2024

Ah, there's already some English-language tests in NumberSpec, of course. I could add Dutch ones but that'd break without an actual implementation, so let's think about that first.

And this is where we have an interesting situation, at least in Dutch... There's two valid ways of specifying an ordinalized number. You can add either an "e", which works for all numbers (1e, 2e, 3e, 1000e), or you could go all fancy and use the more irregular version (1ste, 2de, 3de, 1000ste).

In fact, I'm pretty certain there's more than one way of using ordinals in other languages as well; if I'm not mistaken, in German you can have some letters OR a period, and in French it might even depend on the gender of the word the ordinal has a relation to... (I looked it up: that's only needed for "first", for the rest you get away with just adding an "e": http://french.about.com/od/vocabulary/a/ordinalnumbers.htm).
Anyway, to add localized ordinal support, you may also have to deal with what comes after the ordinal.

Back to just starting with adding one language: I don't think the Symfony translation interface is useful here, since you need to add actual logic (at least for English, preferrably for other languages as well). I'll think of something, PR it, and then we can take shots at it, OK?

from php-humanizer.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.