Add free label to free section of trial course in My Course Activity about cbonlineapp HOT 29 CLOSED

@SaumyaSingh1 You have to mark the sections of course content that are free, I guess.

Also, sorry, I won't be able to work on this issue anymore.

from cbonlineapp.

Go ahead

from cbonlineapp.

I would like to solve this issue

from cbonlineapp.

But free label is already marked here.

Am I right ? Please guide .

from cbonlineapp.

Add it to course individual sections

from cbonlineapp.

Free label in few sections , is it something like this ...

from cbonlineapp.

Yes exactly like this

from cbonlineapp.

so, upto how many sections should we mark free label ? And are we supposed to do this in all the courses ?

from cbonlineapp.

For all the sections which are not premium and obviously yes for all the courses

from cbonlineapp.

okay :)

from cbonlineapp.

@aggarwalpulkit596 I have added the free label . looks like this ..

But right now the label is for all sections . Need sometime to make it confined to the sections which are not premium :)

from cbonlineapp.

Does it good to you ? I don't think so make design similar to website

from cbonlineapp.

Okay i will make design similar to the website .

from cbonlineapp.

@aggarwalpulkit596 From where can we know that which courses are free and which are not??

from cbonlineapp.

I am also at this stage and now i just want to know that from where i can get the data that which courses are free and which are not????

from cbonlineapp.

I did it.
Is it alright or @aggarwalpulkit596 you need more modificitaions??
Its working fine for all the courses.

from cbonlineapp.

Its all set now looking exactly like the website can i send a pr now??? @aggarwalpulkit596

from cbonlineapp.

If @SaumyaSingh1 is okay with this you can send a PR @shubhamofbce

from cbonlineapp.

@aggarwalpulkit596 please review

from cbonlineapp.

@shubhamofbce i told you @SaumyaSingh1 asked it first if she doesn't make a pr by tomorrow I'll your pr

from cbonlineapp.

But i asked to work on this first , You can see the comments from the begining. I asked two days ago she commented today.

from cbonlineapp.

@SaumyaSingh1 i guess it's okay then

from cbonlineapp.

@aggarwalpulkit596 Because of my exams i was not able to complete the task . But I have done half of the work .
Issue is still open ! are we still supposed to resolve same problem.
Thanks for the guidance @aggarwalpulkit596

from cbonlineapp.

@SaumyaSingh1 yeah you can still work on this follow the design which @shubhamofbce used but his method was incorrect so i had to revert that

from cbonlineapp.

Okay

from cbonlineapp.

Did @SaumyaSingh1 resolved the issue or is it still open??? @aggarwalpulkit596

from cbonlineapp.

It is still open

from cbonlineapp.

@aggarwalpulkit596 I made a pr with proper logic this time do check it.

from cbonlineapp.

@aggarwalpulkit596 #209 has no conflicts and got all tests passed too. please review for one last time.

from cbonlineapp.