Giter Club home page Giter Club logo

Comments (4)

gaetan-hexadog avatar gaetan-hexadog commented on June 12, 2024 1

You're right the issue was the place were I declared Route::fallback(\CodeZero\LocalizedRoutes\Controllers\FallbackController::class);

Thanks a lot for your help.

from laravel-localized-routes.

ivanvermeyen avatar ivanvermeyen commented on June 12, 2024

Hi,

This should be possible by using the auto redirect feature.

Set the config option redirect_to_localized_urls to true, and register the following fallback route with the FallbackController at the end of your routes/web.php file.

Route::fallback(\CodeZero\LocalizedRoutes\Controllers\FallbackController::class);

from laravel-localized-routes.

gaetan-hexadog avatar gaetan-hexadog commented on June 12, 2024

I already use it but unfortunately if I set up the omitted_locale to en (for ex) and type /en/about/ url in my browser I get the 404 not found error. It's because this route is considered as a fallback route apparently.

The omitted_locale config works for the other way (recognizing /about url as en/about internally)

from laravel-localized-routes.

ivanvermeyen avatar ivanvermeyen commented on June 12, 2024

That's weird. I just did a sanity check and tried it on a project.
It's working as expected here.
There are also tests for this, but maybe I missed something.

In the FallbackController, this should return the /about URL:

$localizedUrl = Route::localizedUrl();

That route should exist so it shouldn't be a fallback.

It's important that the Fallback route is the very last route you register, because it's a catch all.

Also, I pushed a bug fix yesterday. I don't think it's related, but you never know.
Is the SetLocale middleware applied to the Fallback route?

from laravel-localized-routes.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.