Makefile is broken about codespell HOT 15 CLOSED

from codespell.

Actually most of the Makefile seems obsolete, it should probably be dropped to the profit of setuptools, or rewritten.

from codespell.

I agree. Something that does not work should be removed.

In order for setuptools to work correctly, bin/codespell.py should be renamed to bin/codespell, since its an executable.

from codespell.

from codespell.

not to change the filename if possible

Prior the recent refactoring the name was codespell.

from codespell.

Looking back at the repo before the refactoring I see codespell.py in the repo:

https://github.com/lucasdemarchi/codespell/tree/4cb7fe36d34784fcb11600834e39c001bee72b2c

Did it get installed as codespell when doing the installation step?

from codespell.

The rename was done by Makefile rule https://github.com/lucasdemarchi/codespell/blob/4cb7fe36d34784fcb11600834e39c001bee72b2c/Makefile#L16

from codespell.

It does break current operating system packages, and would require lots of otherwise unnecessary patching. Please rename it.

This would actually preserve backward compat.

from codespell.

http://python-packaging.readthedocs.io/en/latest/command-line-scripts.html

This link also suggests that executable scripts should drop the file extension

from codespell.

Does #89 look right to you?

from codespell.

I think the Makefile should also be removed in this process. If it doesn't work, its useless and irritating. Otherwise it looks good to me.

from codespell.

@cinemast do you have time to make a PR to remove the Makefile?

from codespell.

Well of course I can, but what is preventing you from simply deleting the Makefile?

from codespell.

I would prefer to make a PR to do it (even if I did it myself) so that people get notified, etc.

from codespell.

(and I haven't contributed to this repo long enough to know what the direct-commit policy is like)

from codespell.