Giter Club home page Giter Club logo

Comments (18)

larsoner avatar larsoner commented on June 24, 2024 3

Yes that's the next step, I should have time by next week

from codespell.

larsoner avatar larsoner commented on June 24, 2024 3

https://pypi.python.org/pypi/codespell/

from codespell.

larsoner avatar larsoner commented on June 24, 2024 2

I have verified locally that setuptools does indeed install a codespell.exe for Windows so just doing codespell works there with #136

from codespell.

larsoner avatar larsoner commented on June 24, 2024

It follows a more standard Python lib pattern to put it in bin. Really most people will / should probably now install via pip and thus just be able to do codespell.py directly

from codespell.

gemal avatar gemal commented on June 24, 2024
    copying build/scripts-3.4/codespell.py -> /home/scrutinizer/.pyenv/versions/3.4.1/bin
    changing mode of /home/scrutinizer/.pyenv/versions/3.4.1/bin/codespell.py to 775

is this normal? That I cant just run codespell.py but it seems only to be able able in /home/scrutinizer/.pyenv/versions/3.4.1/bin/codespell.py ?

from codespell.

lurch avatar lurch commented on June 24, 2024

most people will / should probably now install via pip and thus just be able to do codespell.py directly

...except now that pypi has been upgraded ( #101 ), pip will actually install the executable codespell instead of codespell.py

from codespell.

larsoner avatar larsoner commented on June 24, 2024

Argh, you're right. I guess we should revert to codespell.py for backward compatibility reasons

from codespell.

larsoner avatar larsoner commented on June 24, 2024

@lucasdemarchi do you agree we should change the name to bin/codespell.py instead of bin/codespell? I think it's necessary for backward compatibility.

from codespell.

lurch avatar lurch commented on June 24, 2024

Isn't it 'better' to have installed commands without the extension? (I assumed this change was deliberate)

from codespell.

larsoner avatar larsoner commented on June 24, 2024

Yeah it is better, but I'm worried about backward compatibility. For people who used to do codespell.py it won't work anymore. So I'm starting to think we should use the old name.

from codespell.

anatol avatar anatol commented on June 24, 2024

Please keep codespell file without file extension. It has been done this way for a long time. The convention has been changed in previous release and that is why we requested reverting it back to codespell.

from codespell.

larsoner avatar larsoner commented on June 24, 2024

Ahh okay, thanks @anatol

from codespell.

jviotti avatar jviotti commented on June 24, 2024

But the problem is that removing .py breaks the tool Windows, which relies on extensions to know how to execute a file. Could we have codespell.py for Windows, and just codespell elsewhere?

from codespell.

larsoner avatar larsoner commented on June 24, 2024

Should we just provide both, then?

from codespell.

larsoner avatar larsoner commented on June 24, 2024

Could we have codespell.py for Windows, and just codespell elsewhere?

I guess that's an option, too. I'll look and see what happens with binaries installed from other repos I work on. I know we have command-line utilities and AFAIK we don't do anything special for Windows. It's possible that they have just never worked there, I guess.

from codespell.

larsoner avatar larsoner commented on June 24, 2024

I guess that you can use setuptools to take care of it. This might be the best/simplest route. Someone want to give it a try?

from codespell.

lurch avatar lurch commented on June 24, 2024

Woohoo, great to see this issue fixed 👍 Any chance of a release on PyPi? ;)

from codespell.

jviotti avatar jviotti commented on June 24, 2024

Has the release been published?

from codespell.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.