Giter Club home page Giter Club logo

Comments (26)

CompuIves avatar CompuIves commented on August 24, 2024 2

I just deployed the new console with this #266.

I'm sorry for the silence @varenya, I already started working on the styling and thought that it would be quicker to quickly move the eval to the sandbox with it. I hope I'm not discouraging you from any further contributions to CodeSandbox. You can join our Discord (https://discord.gg/KE3TbEZ) if you want a quicker answer or to chat about ideas 😄 .

from codesandbox-client.

CompuIves avatar CompuIves commented on August 24, 2024

This will be integrated using a custom renderer, issue is here: #31

from codesandbox-client.

CompuIves avatar CompuIves commented on August 24, 2024

Decided that this will not be done by the custom renderer, this functionality is global. Also I think that it should be on the right side (under the preview), since this console is used for preview.

from codesandbox-client.

renanpvaz avatar renanpvaz commented on August 24, 2024

I'd like to help if possible. Do you already have an idea of how this should this be done? In which context should this console execute?

from codesandbox-client.

lbogdan avatar lbogdan commented on August 24, 2024

@renanpvaz Do you want to take this? I already started playing with it, only got some layout going so far, no functionality. Let me know, so we don't both work on the same feature. 😄

from codesandbox-client.

renanpvaz avatar renanpvaz commented on August 24, 2024

@lbogdan oh don't mind me, if you've started it then keep it up.

from codesandbox-client.

Hum4n01d avatar Hum4n01d commented on August 24, 2024

+1 Yes please!

from codesandbox-client.

varenya avatar varenya commented on August 24, 2024

is someone still working on this? If any help needed would love to contribute :)

from codesandbox-client.

lbogdan avatar lbogdan commented on August 24, 2024

@varenya You can find the work so far here https://github.com/lbogdan/codesandbox-client/tree/feature/preview-console, if you want to take a look.

from codesandbox-client.

varenya avatar varenya commented on August 24, 2024

sure thanks, should I fork this branch repo to contribute? is any help needed :)?

from codesandbox-client.

lbogdan avatar lbogdan commented on August 24, 2024

@CompuIves did you manage to do anything about this? I, for one, was a bit busy with life these last couple of weeks. 😞

from codesandbox-client.

CompuIves avatar CompuIves commented on August 24, 2024

from codesandbox-client.

varenya avatar varenya commented on August 24, 2024

@lbogdan you have used react-console here and it looks to be working what else is pending here?
@CompuIves any inputs let me know I can help.

from codesandbox-client.

CompuIves avatar CompuIves commented on August 24, 2024

from codesandbox-client.

varenya avatar varenya commented on August 24, 2024

No, I just checked he's doing it in Preview/index.js, basically what you just said postMessage and then switching based on the type and logging it on the react-console.

from codesandbox-client.

CompuIves avatar CompuIves commented on August 24, 2024

from codesandbox-client.

lbogdan avatar lbogdan commented on August 24, 2024

@CompuIves Unfortunately I didn't, the eval part is not done yet. For this we should also change react-console, which is currently doing the eval internally. So 2. is still pending.

from codesandbox-client.

varenya avatar varenya commented on August 24, 2024

@lbogdan what do you mean by eval? but the flow is as @CompuIves mentioned right i.e. postMessage etc..

from codesandbox-client.

lbogdan avatar lbogdan commented on August 24, 2024

I mean when you write something in the console and it evals and displays it:

In this example, it should evaluate it in the sandbox preview context and show href: "http://localhost:3001/".

from codesandbox-client.

varenya avatar varenya commented on August 24, 2024

hmm understood but any ideas how to go abt it?

from codesandbox-client.

Hum4n01d avatar Hum4n01d commented on August 24, 2024

You could look at the applicable JSBin code; they do it quite nicely

from codesandbox-client.

varenya avatar varenya commented on August 24, 2024

yeah, but they don't need to maintain preview context like in this case. And they are not using iframes either. let me see thanks for your inputs.

from codesandbox-client.

varenya avatar varenya commented on August 24, 2024

Can somebody help me with high-level overview of the project as in how parts are connected so that I can hack on it faster?

from codesandbox-client.

Hum4n01d avatar Hum4n01d commented on August 24, 2024

I just noticed this! Great job on the console @CompuIves

from codesandbox-client.

Hum4n01d avatar Hum4n01d commented on August 24, 2024

It's really nice to have the errors printed out there since the computer I'm currently using doesn't have access to the dev tools :(

from codesandbox-client.

IAMtheIAM avatar IAMtheIAM commented on August 24, 2024

It would be great if we could have this console open by default on our codesandboxes, right now it's "click to open"

from codesandbox-client.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.