Comments (4)
Because it’s not common practice for built-ins, there is a lot ways to import
module like fs
or any module from the wild:
import ‘fs’;
import ‘mock-import’;
That has no sense. Also with help of ignore option any most used this way modules can be listed and excluded.
Do you have a list of such modules?
from putout.
Not sure about built-ins, but empty imports are used pretty often by 3rd-party libraries.
Thanks for clarifications, I decided to disable remove-empty/import
(along with import/no-unassigned-import
) in eslint-config-hardcore: https://github.com/EvgenyOrekhov/eslint-config-hardcore/releases/tag/v19.10.0.
from putout.
I see that jest-dom suggest to use:
import '@testing-library/jest-dom'
Let's look what is inside src/extend-expect.js:
import * as extensions from './matchers'
expect.extend(extensions)
You can use similar approach and this is is more obvious to understand what is going on here without any documentation. supertape behave in a similar way:
const {extend} = require('supertape');
const test = extend({
transform: (operator) => (a, b, message = 'should transform') => {
const {is, output} = operator.equal(a + 1, b - 1);
return {
is,
output,
};
},
});
test('assertion', (t) => {
t.transform(1, 3);
t.end();
});
With no pollution of global scope. Many task runners adds global variables but I don't think this is a good practice for example js-based Test Anything Protocol runners can work without separated utility you just execute your test with:
node test.js
And it just works as any other script, with jest
, mocha
etc you can't do such a trick.
Anyways jest
is very good task runner with a lot of features, supertape
is the complete oppositeЖ the realm of minimalism :).
Also worth mention that: Explicit is better than implicit according to Zen of Python. Also such a way is violates Principle of least astonishment: when you see empty import
first thing you want to do is delete it (if it's not css
in React Component
of course).
from putout.
I agree that it would be better to avoid unassigned imports, but unfortunately many libraries recommend using unassigned imports in the official docs, and it just becomes annoying to see false-positive warnings from import/no-unassigned-import
and remove-empty/import
.
from putout.
Related Issues (20)
- question: how can I use putout to transform unicode regexes (/../u)? HOT 4
- How to disable pretty printer HOT 12
- Could not resolve dependency when installing latest eslint-plugin-putout HOT 4
- Getting error for apply-nullish-coalescing HOT 7
- TypeScript type being removed in output when using object destructuring HOT 2
- Callstack error on version 32.1.x or newer HOT 12
- TypeScript union type as a key turns into extends expression HOT 2
- TypeScript interface `extends` gets removed HOT 1
- Eslint Plugin Relying on Stylistic HOT 6
- 404 Page of Node v12 link in README. HOT 2
- convert-commonjs-to-esm/exports not working HOT 8
- Double quotes to single quotes conversion creates syntax error HOT 3
- question: how can i disable all plugins that are not in the rulesdir? HOT 3
- [printer] [bug] HOT 2
- Question: Reverse mode HOT 4
- Wrong transform with @putout/plugin-for-of HOT 15
- Incorrect order of initialization of variables HOT 4
- Incorrect removing of an expression HOT 2
- ignore test files HOT 5
- path is missing for ruler toggler HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from putout.