convert-commonjs-to-esm doesn't work about putout HOT 6 CLOSED

It works now, thank you!

from putout.

As I see, your package.json doesn't have type field, so ESM test.js would not work any way (unless you rename it to test.mjs). Also you requiring json files supported only with nodejs flag --experimental-json-modules. What do you want test.js transformed to?

Using simport:

import {createCommons} from 'simport';
const {require} = createCommons(__import.meta.url);

// and then you can use `require` in `ESM`

or

import "./base.json";

And you should use --experimental-json-modules

from putout.

I'm trying to understand how it's supposed to work.

I just tried adding "type": "module" to my package.json, and I still see no warnings from Putout:

from putout.

The most common cases supported right now, like:

-const fs = require(‘fs’);
+import fs from ‘fs’;

Right nowtop-level-require, which is not assigned to anything, like:

require(‘some-module’);

Not handled at all. I’m wandering how to handle it properly.

from putout.

Oh, right, of course!

OK, I'm trying it, but still can't make it work. Could you please check out this PR: EvgenyOrekhov/eslint-config-hardcore#281 and tell me why is there no warning from convert-commonjs-to-esm?

You can see it in CI report that there is a warning about "use strict", but there is no warning about require:

from putout.

Looks like it is related with configuration of convert-commonjs-to-esm, the whole rule is disabled by default with:

{
    "rules": {
        "convert-commonjs-to-esm": "off"
    }
}

And when you partially enable it with:

{
    "rules": {
        "convert-commonjs-to-esm": "off",
        "convert-commonjs-to-esm/require": "on",
        "convert-commonjs-to-esm/exports": "on"
    }
}

It's do not get loaded, so one of solutions could be to enable the whole rule, and then disable parts you don't need.
Anyways it looks useful, worth fixing and landed in @putout/engine-loader v4.3.0 🎉 .

Is it works for you :)?

from putout.