Comments (4)
Hi @Team,
Good job so far!
There are some issues that you still need to work on to go to the next project but you are almost there!
Highlights
Required Changes ♻️
- Let's be more detailed in tasks. Instead of writing "implement Items, Book and Author classes" as one task you can split it into different achievable tasks following project requirements details.
- Add some missing tasks like Add unit tests for all implemented methods.
- Also, following project requirements some tasks should be assigned to a group.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100%.
Please, remember to tag me @uwadonat in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
from catalog.
Hi @Bigizi, @coderacheal, and @habasm ✋
Hello ✋, you have done well reaching this point of the milestone 🤝 . But there are some issues that you still need to work on to go to the next project but you are almost there!
This project will be marked as Invalid and won't affect the number of your weekly reviews
- Kindly ensure the issue forwarded for review contains a link to your GitHub project.
Cheers, and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread and tag me @1GORDON
if something is not 100% clear.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think the code review was unfair, request a second opinion using this form.
from catalog.
Hi @Bigizi, @coderacheal, and @habasm ✋
Good job so far!
Hello ✋, you have done well reaching this point of the milestone 🤝 . But there are some issues that you still need to work on to go to the next project but you are almost there!
Status: Required Changes ♻️⛔️
- As requested by the previous reviewer, kindly ensure all group tasks are assigned to the group. The tasks include
Implement methods
: (can_be_archived?() in the Item class, and move_to_archive() in the Item class), andImplement startup actions
.
Check the comments under the review.
Optional suggestions
- As stated in the project requirements, kindly ensure all cards have the [Xpt] prefix which indicates the number of points that show how complex the task is.
- As stated in the project requirements, kindly ensure all cards have a description of the task.
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend considering them as they can improve your code.
Cheers, and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread and tag me @1GORDON
if something is not 100% clear.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think the code review was unfair, request a second opinion using this form.
from catalog.
Hi @Bigizi, @coderacheal and @habasm,
Highlights!
- Descriptive Issue ✔️
Your project is complete! There is nothing else to say other than... it's time to merge it
Congratulations! 🎉
Status: Approved ✔️
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
from catalog.
Related Issues (18)
- [1 pt] Set up the repo - Group task
- [1pt]Create a Game class in a separate .rb file.
- [1pt] Create MusicAlbum class in a separate .rb file
- [2 pt] Implement Item Class- Group Task
- [2 pt] Add Book Class
- [2pt] Add Label to show associations
- [1 pt]Create a main.rb file - Group Task
- [1pt] Add tests for all implemented methods for the Book Class
- [2pt]Create a schema.sql file with tables for all Book and Label Class
- [2pt] Create Genre class with an association to the Item class (in a separate .rb file).
- [2pt] Add unit tests for all implemented methods in the Music Album and Genere class
- [2pt] Create a schema.sql file with table for MusicAlbum and Genre
- [2pt] Create an Author class with an association to the Item class (in a separate .rb file)
- [2pt]Add unit tests for all implemented methods in the game and Author class
- [2pt] Create a schema.sql file with tables for the game and author classes
- [2pt] Implement startup actions - Group task
- [1 pt] Implement methods - Group task
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from catalog.