Update from 1.3.0 to 1.4.2 breaks application, when YII_ENV=test about yii2-localeurls HOT 11 CLOSED

Done!

from yii2-localeurls.

Yes, it's because of this here:
https://github.com/codemix/yii2-localeurls/blob/master/UrlManager.php#L425

It was the only way to test the redirects in the test cases. Hmm. Not sure yet, how to fix this.

from yii2-localeurls.

@schmunk42 Actually I think, you should fix your test cases, so that they don't trigger any redirect from this extension. Your test cases would probably not work correctly anyway if there's a redirect.

from yii2-localeurls.

Hmmm, we explicitly test redirects in our acceptance test cases, since this is one of the parts we often have problems with (eg. wrong SEO indexing, empty pages for en_us while en is fine, etc...).

from yii2-localeurls.

@schmunk42 We already have very extensive tests in the extension itself. We test for all kinds of different scenarios so I don't think you need to test for this again in your app. If you find, that a test is missing I'm happy to include it here.

So can we close this?

from yii2-localeurls.

Yes, closed. Thank you.

from yii2-localeurls.

Can we get something like

if (getenv('LOCALEURLS_TEST')) {

instead of using YII_ENV_TEST? Just pass this by setting a variable or constant in the test config.

Since this component is so deeply integrated into the application lifecycle, it's impossible to work around this issue in acceptance tests.

I'd be ready for a PR about this.

🙇

from yii2-localeurls.

Ok, should not hurt. I've committed a change. Does this solve it for you?

from yii2-localeurls.

Perfect, thank you! A new release would be the last thing ;)

from yii2-localeurls.

Ooops, undefined variable, see PR.

from yii2-localeurls.

Ouch, ok. But no PR so far...?

from yii2-localeurls.