Case sensitivity about yii2-localeurls HOT 8 CLOSED

Hmm, I think this was mainly my personal preference for all lowercase URLs. But I guess you have a valid point here. Can you check if my commit above helps you? It adds an option keepUpperCaseLanguageCode.

from yii2-localeurls.

Thanks! This commit is working for me though consistency is not perfect yet :)

I have prepared table which explains how I see it.

Not sure how hard it is to implement such states (because of additional language detection and maybe other things).

Does it make sence?

from yii2-localeurls.

Config language should never use a lowercase country code, so your line with en-gb is not valid IMO. It must always be en-GB.

I'm also not sure, if we really should be so strict and issue 404 or 302 in the cases you've shown. Notice that you can also use wildcard patterns like en-*. The basic idea was, to make the extension case insensitive with URLs, so that both en-GB and en-gb work - but the former is redirected by default to make URLs unambiguous.

from yii2-localeurls.

Ah, now I understand. I thought that you want to have lowercase codes in configuration also. It is fine how it works now. Thanks for new option!

from yii2-localeurls.

@kavolorn Ok, thanks. I'll create a 1.4.0 release (new feature). Please note that I will rename keepUpperCaseLanguageCode to keepUppercaseLanguageCode (notice the lowercase c). This is more correct as "uppercase" is a single word in english.

from yii2-localeurls.

Alright! Thanks :)

from yii2-localeurls.

Just noticed that default / url redirects only to lowercase version even keepUppercaseLanguageCode is turned on. Is it a big thing to redirect to uppercase version by default (if option specified)? Thx

from yii2-localeurls.

Confirmed and (hopefully) fixed in brandnew release 1.4.2 ;)

from yii2-localeurls.