Comments (10)
I see your point but this is not supported (yet). URL parsing happens after localeurls has done its job. So the extension has no information about the current controller or module as this is decided later on.
I'm unsure how we could implement this. We could maybe add some regular expression URL patterns that if matched during parsing will skip language processing. And also a list of route patterns, where language should be ignored when building a URL.
from yii2-localeurls.
Thanks for your reply. So, this is not a edge case I promise. Currently I taking a look on your codes. Its seem not that complicated to define exclude url patterns.
While this extension is executed before a controller/module was initialized its the best way to define exclude routes. Do you agree to that?
from yii2-localeurls.
What about: Simple but works for this moment. If you want me to make a pull request... ;) ?
Configuration File
'urlManager' => [
'class' => 'codemix\localeurls\UrlManager',
'languages' => [
'en' => 'en-gb',
'de' => 'de-de'
],
'enableLanguageDetection' => false,
'enablePrettyUrl' => true,
'showScriptName' => false,
'rules' => [
],
'filter' => [
'api/',
'test/'
]
],
Configuration attributes
/**
* Array of filtered URL route strings
* @param array
*/
public $filter = array();
And in protected function processLocaleUrl($request)
line 189+
//filter routes
foreach ($this->filter as $filter) {
if (preg_match("#^($filter)\b(/?)#i", $pathInfo)) {
return true; //proceed with application
}
}
from yii2-localeurls.
Yeah, something like this. But you also need something for URL creation. So we need to specify a list of routes or - even better - another regular expression pattern that matches many routes (otherwhise you'd have to manually specify all action routes available e.g. from a module).
from yii2-localeurls.
For this moment, a static pattern would be enough.
from yii2-localeurls.
@linslin Can you check if my implementation in this branch here works for you?
https://github.com/codemix/yii2-localeurls/tree/25-ignore-patterns
For configuration see here:
https://github.com/codemix/yii2-localeurls/blob/25-ignore-patterns/UrlManager.php#L75
from yii2-localeurls.
@linslin Any news here? Did you get a chance to try the new implementation?
from yii2-localeurls.
Hey @mikehaertl sorry for this late answer. The new feature works pretty nice. Thanks so far!
from yii2-localeurls.
Great. I'll prepare a 1.2.0 release with this new feature then.
from yii2-localeurls.
👍
from yii2-localeurls.
Related Issues (20)
- Problem with default language HOT 3
- Redirect from https to http HOT 1
- Ajax also redirects when enableLanguagePersistence is turned on HOT 2
- Regular expression trouble HOT 5
- Using GeoIp as primary language detection method HOT 2
- Support for different domains HOT 2
- The page keeps redirecting HOT 1
- index.php is shown in browser url HOT 1
- How can i change language position in url HOT 2
- Please fix this define HOT 3
- Url::to with rules HOT 1
- One language for all EU locales HOT 1
- Problem with change language under Windows HOT 3
- Some issues with yii2-localeurls
- using Yii functionality HOT 2
- Bug in tests HOT 1
- The configuration for the "localeUrls" component must contain a "class" element. HOT 1
- Generating URL with custom urlRule HOT 2
- Help me please. Error with route. HOT 3
- Redirect for specific languages HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from yii2-localeurls.