Giter Club home page Giter Club logo

Comments (4)

DavidNoftsier avatar DavidNoftsier commented on August 21, 2024

I have made some basic changes to the App.js file to improve readability and separated some logic out to other files where possible. I think we will want to move the callSheets and normalizeHeaders functions to a separate file at some point, which would help clarify and shorten the app.js file.

I have been looking at how to handle state, perhaps we can use the React Context API instead of adding the overhead of Redux. I think the Map component could be a good candidate to handle its own state, and this would allow us to move several functions (onMouseEnter, onMouseLeave, possibly onOrganizationClick) out of App.js entirely. I am wary of moving the state management until I learn more about the best practices for state handling.

If anyone has an opinion on any of this please let me know. I will continue researching state management for now

from communityconnect.

Khoawala avatar Khoawala commented on August 21, 2024

Can you make a pull request with what you have? I want to refactor some components. I've separated the Header into smaller components so avoid the Header.js file to avoid merge conflicts.

from communityconnect.

DavidNoftsier avatar DavidNoftsier commented on August 21, 2024

Absolutely @Khoawala, I just made a pull request (#71 ) with what I have

from communityconnect.

DavidNoftsier avatar DavidNoftsier commented on August 21, 2024

The to do list is as follows for refactoring App.js

  • Refactor JSX structures for readability

  • Move callSheets logic to separate file

  • Move normalizeHeaders logic to separate file

  • Consolidate map related state handling and logic to exist in the Map component

  • Move sorting and ResultList related state handling and logic to ResultList component

  • Move location related logic to utility file or Map component

  • Move components to individual folders

from communityconnect.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.