Comments (6)
As already said on Discord, my opinion:
Locally I'd prefer to not have strict mode enabled since it's more convenient to test/implement things without fixing small syntax inconsistencies. Once you are ready to commit you should then resolve all the warnings.
But I'm open to other's opinions.
from codeedit.
I think it is a good idea, to set the local environment to strict.
Otherwise people will create a PR, and SwiftLint will fail, but not locally.
while in development you can always use:
// swiftlint:disable RULENAME
,// swiftlint:enable RULENAME
// swiftlint:disable:next RULENAME
// swiftlint:disable:previous RULENAME
// swiftlint:disable all
// swiftlint:enable all
Maybe it's a good idea to implement something like remove_todos.sh to check for // swiftlint:disable all
, or // swiftlint:disable
things, in case people forget them.
personally i think // swiftlint:disable RULENAME
is placed intended, // swiftlint:disable all
can never be intended.
from codeedit.
Good point. I agree
from codeedit.
What about adding a pre-commit hook to forbid commit if swiftlint --strict
failed and keep local environment normal?
from codeedit.
What about adding a pre-commit hook to forbid commit if
swiftlint --strict
failed and keep local environment normal?
Yes and no,
If you make the local environment strict, then you'll see the errors in Xcode, otherwise only in the terminal.
personally i like it more if i see the errors in Xcode instead of the terminal.
from codeedit.
A agree with @wdg. I think no one will commit a build containing errors. And even if so we still have the workflow as a safe guard.
from codeedit.
Related Issues (20)
- ✨ Enable User to Choose a Selection Color In Themes Settings HOT 1
- ✨ Enable User to Choose a Cursor Color In Themes Settings
- ✨ Enable User to Choose a Current Line Color In Themes Settings
- ✨ Enable User to Bold and Italicize Text in Theme Settings
- ✨ Standardize Themes HOT 3
- ✨ ^⌘0 should reset font size back to default HOT 3
- 🐞 Autosave broken HOT 3
- 🐞 CodeEdit is hanging when open new window HOT 2
- ✨ Can macOS12 version be supported? HOT 1
- 🐞 Can not close or adjust debug panel after adjust debug panel to maximum height HOT 4
- Support Gitea
- I really wanna see such a perfect app for andriod.😃 HOT 2
- 🐞 Git branches selector doesn't allow to scroll HOT 1
- ✨ Git branches selector quality of life improvements HOT 1
- ✨ Repositories list tags and remotes HOT 1
- 🐞 Problem with the color of the icons HOT 7
- 🐞 Fuzzy Search not working as expected
- 🧐 Research a new solution for file management HOT 1
- ✨ Pull requests section to be able to add a new remote
- 🐞 C++ "<<" attempts to autocomplete even after disabling completing quotations HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from codeedit.