Giter Club home page Giter Club logo

Comments (3)

sockdrawermoney avatar sockdrawermoney commented on August 26, 2024

Keys are disabled and I'm working on mitigating this. These keys were set in netlify and createIssue.js should be running as a lambda function... so I'm a bit concerned here about either my understanding of netlify's lambda function setup or netlify's security or both.

Told wardens to standby for a new process for submissions.

from 2021-04-marginswap-findings.

sockdrawermoney avatar sockdrawermoney commented on August 26, 2024

There are two problems:

  1. My total misunderstanding of how netlify's lambda functions work. Cue * whooshing noise * of lambda going over my head. Best thing about being wrong though is you get to be right again :)
  2. If you put lambda functions directory inside the src directory, netlify will go ahead and add your environment variables in plain text and deploy them as part of your site. 😂

Working on updates.

In the meantime, I have taken the form offline and instructed wardens to keep their own notes on vulnerabilities until the form is ready for submissions.

from 2021-04-marginswap-findings.

sockdrawermoney avatar sockdrawermoney commented on August 26, 2024

@werg @marginswapper @zscole This is now resolved. Or should be, at least!

Form is back online at https://c4-marginswap.netlify.app/

from 2021-04-marginswap-findings.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.