Comments (3)
Keys are disabled and I'm working on mitigating this. These keys were set in netlify and createIssue.js
should be running as a lambda function... so I'm a bit concerned here about either my understanding of netlify's lambda function setup or netlify's security or both.
Told wardens to standby for a new process for submissions.
from 2021-04-marginswap-findings.
There are two problems:
- My total misunderstanding of how netlify's lambda functions work. Cue * whooshing noise * of lambda going over my head. Best thing about being wrong though is you get to be right again :)
- If you put lambda functions directory inside the
src
directory, netlify will go ahead and add your environment variables in plain text and deploy them as part of your site. 😂
Working on updates.
In the meantime, I have taken the form offline and instructed wardens to keep their own notes on vulnerabilities until the form is ready for submissions.
from 2021-04-marginswap-findings.
@werg @marginswapper @zscole This is now resolved. Or should be, at least!
Form is back online at https://c4-marginswap.netlify.app/
from 2021-04-marginswap-findings.
Related Issues (20)
- [INFO] allTranches array is unbounded HOT 1
- [INFO] liquidators may be a subject of front-running attacks HOT 1
- [Gas] Error codes
- [Gas] same calculations are done twice
- [Gas] unused variables HOT 1
- [Gas] only process value if amount is greater than 0
- [Gas] Not used imports
- [Gas] Extract storage variable to a memory variable
- [Gas] Do not send value if holdingsValue is 0
- Not emitting event for important state changes HOT 2
- [Gas] Useless addition of 0
- Testing simpler form HOT 1
- Inconsistent usage of applyInterest HOT 1
- Impossible to call withdrawReward fails due to run out of gas HOT 1
- The First User To Borrow a Particular Token Can Drain Funds In MarginSwap by Making An Undercollateralized Borrow Using Flash Loans HOT 2
- Users Can Drain Funds From MarginSwap By Making Undercollateralized Borrows If The Price Of A Token Has Moved More Than 10% Since The Last MarginSwap Borrow/Liquidation Involving Accounts Holding That Token. HOT 2
- Inconsistent Use of RoleCache in RoleAware.sol HOT 1
- Duplicated Code In Admin.viewCurrentMaintenanceStaker()
- Add a timelock to functions that set key variables HOT 2
- Magic Numbers used in Admin._stake() When Constant Defined Above Can Be Used Instead
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from 2021-04-marginswap-findings.