Giter Club home page Giter Club logo

Comments (16)

coddec avatar coddec commented on August 19, 2024 2

@war59312 Thanks for the link, the error is about the version of Visual Studio the project used, I've already resolved multiple project issue mentioned in the link you given. ;)
Cheers

from classic-shell.

coddec avatar coddec commented on August 19, 2024

@rgl

it would be nice to have this code build automatically on appveyor.com.

Created one, not sure if it will work until there's some new code though I guess

from classic-shell.

coddec avatar coddec commented on August 19, 2024

Everything configured, get following error, tried to upgrade from VS2008 to VS2017 project locally, brings up some warnings. Instead of break anything, I'll wait & see if anyone else can do it correctly without break anything and hopefully can share the procedure with me.

https://ci.appveyor.com/project/coddec/classic-shell/branch/master
The project file "ClassicExplorer\ClassicExplorer.vcproj" is in the ".vcproj" file format, which MSBuild no longer supports. Please convert the project by opening it in the Visual Studio IDE or running the conversion tool, or use MSBuild 3.5 or earlier to build it.

AppVeyor build screenshot

Screen

from classic-shell.

war59312 avatar war59312 commented on August 19, 2024

@coddec Could probably get assistance @ https://help.appveyor.com/discussions/problems/7200-specify-which-project-or-solution-file-to-use-because-the-folder-contains-more-than-one-project-or-solution-file

from classic-shell.

IkeKap avatar IkeKap commented on August 19, 2024

@coddec what were the specific warnings Visual studio displayed during the conversion process? Also would it be possible to branch off the converted file so it would be easier for multiple people to attempt to resolve the issues as they appear?

from classic-shell.

IkeKap avatar IkeKap commented on August 19, 2024

It seems that allowing pull request #7 would open the way to solving this issue @coddec

from classic-shell.

coddec avatar coddec commented on August 19, 2024

@IkeKap I agree, just waiting someone who can review the changes just in case then we can merge it, hopefully that will resolve this issues too ;)

from classic-shell.

H3rmit avatar H3rmit commented on August 19, 2024

so, is anyone going to keep this project alive? I really hope so!

from classic-shell.

XenHat avatar XenHat commented on August 19, 2024

I cannot afford appveyor membership at the moment so my help will be very limited however there is a template for the .appveyor.yaml file here and some alternate instructions from the support staff concerning multiple projects building have been provided in this answer.

TL;DR:

    matrix: 
      - project_name: src/Project1/XXXX.YYY.Project1.sln 
      - project_name: src/Project2/XXXX.YYY.Project2.sln 
      - project_name: src/Project3/XXXX.YYY.Project3.sln 
      - project_name: src/Project4/XXXX.YYY.Project4.sln 
      - project_name: Shared/Foldername/somesolution.sln

and then

  build: 
    verbosity: normal 
    project: $(project_name)

EDIT: #7 indeed builds and runs, however unconfigured appveyor does not appear to want to build it.

from classic-shell.

coddec avatar coddec commented on August 19, 2024

@XenHat Thanks for the approval and information for appveyor, since this project is open source, if I remember right, we can use appreyor for free ;) so.. no need to pay for anything. Don't worry 😄

from classic-shell.

coddec avatar coddec commented on August 19, 2024

Ummmmm, new error?
screenshot-2018-2-2 classic shell 4 3 1 1 - appveyor

from classic-shell.

XenHat avatar XenHat commented on August 19, 2024

I wonder if appveyor cleaned the previous artifacts mid-build.. 🤔

from classic-shell.

ge0rdi avatar ge0rdi commented on August 19, 2024

@coddec
You need to build Setup configuration, first 64bit then 32bit.

I'm trying to get Appveyor builds working (this is my first experience with it). Though I cannot choose Win32 platform in settings. There is only x86 and x64 (which builds just fine btw).

So I'm running BuildBinaries.bat directly. Here is appveyor.yml config that I'm using currently:

version: 1.0.{build}
image: Visual Studio 2017
shallow_clone: true
build_script:
- cmd: >-
    cd ClassicShellSrc\ClassicShellSetup
    BuildBinaries.bat

This produces just binaries.
https://ci.appveyor.com/project/ge0rdi/classic-shell/build/1.0.3

I'm also trying to build full installer with Appveyor. But this requires WiX (should be installed, but doesn't work for me right now) and HTML Help Workshop (this doesn't seem to be installed in build environment). Also I guess we'd need to replace WinRar with 7zip.

from classic-shell.

coddec avatar coddec commented on August 19, 2024

@XenHat Ummm, I think it did, cause I deleted previous build.
@ge0rdi My first experience too :D
Yes, I guess we need to replace WinRar with 7zip

Here's my current appveyor.yml

version: 4.3.1.{build}
pull_requests:
do_not_increment_build_number: true
branches:
only:
-master
image: Visual Studio 2017
build:
project: C:\projects\classic-shell\ClassicShellSrc\ClassicShell.sln
verbosity: minimal

appveyor.yml.zip

from classic-shell.

ge0rdi avatar ge0rdi commented on August 19, 2024

@coddec
I've pushed few changes to appveyor branch.
It is now possible to build full installer from that branch using this config:

version: 4.4.{build}
pull_requests:
  do_not_increment_build_number: true
image: Visual Studio 2017
shallow_clone: true
install:
- cmd: set PATH=C:\Program Files (x86)\WiX Toolset v3.11\bin;C:\Program Files (x86)\HTML Help Workshop;%PATH%
build_script:
- cmd: >-
    cd ClassicShellSrc\ClassicShellSetup

    __MakeFinal.bat
test: off
artifacts:
- path: ClassicShellSrc\ClassicShellSetup\Final\*.exe

Look here:
https://ci.appveyor.com/project/ge0rdi/classic-shell/build/4.4.8/artifacts
(hope you can access it)

I will push that config to the branch, just want to check few things out.

Also not sure about the versioning. I'd suggest to continue from next minor version (4.4).
Next thing in my TODO list is to use appveyor's version in actual build - version info of executables, name of installer, etc.

from classic-shell.

coddec avatar coddec commented on August 19, 2024

@ge0rdi Sure, you can push it anytime.
@ me if there's any pushing/permission issue.
Next minor version sounds fine to me ;)
Cheers!

from classic-shell.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.