Giter Club home page Giter Club logo

Comments (11)

cod3licious avatar cod3licious commented on May 28, 2024 1

@mglowacki100 this is what it looks like for me:

Screenshot 2023-05-05 at 09 40 01

from autofeat.

cod3licious avatar cod3licious commented on May 28, 2024 1

wow, what a horrible UX. sorry, now you should see it

from autofeat.

cod3licious avatar cod3licious commented on May 28, 2024 1

Thanks so much, I merged the changes and will release a new version next weekend (since I also wanted to make sure the code works with the new sklearn versions and everything)

from autofeat.

mglowacki100 avatar mglowacki100 commented on May 28, 2024 1

@cod3licious Thanks, it works correctly :)

from autofeat.

cod3licious avatar cod3licious commented on May 28, 2024

Great idea! Unfortunately, I don't know when I'll get to that, but pull requests are always welcome!

from autofeat.

mglowacki100 avatar mglowacki100 commented on May 28, 2024

Hi
@cod3licious cod3 as far I see and after running local test it seems enough to add method predict_proba as minimally modified predict method to class AutoFeatModel(BaseEstimator)

    def predict_proba(self, X):
        """
        Inputs:
            - X: pandas dataframe or numpy array with original features (n_datapoints x n_features)
        Returns:
            - y_pred: predicted targets probs return by prediction_model.predict_proba()
        """
        check_is_fitted(self, ["prediction_model_"])
        # store column names as they'll be lost in the other check
        cols = [str(c) for c in X.columns] if isinstance(X, pd.DataFrame) else []
        # check input variables
        X = check_array(X, dtype=None)
        if not cols:
            cols = ["x%03i" % i for i in range(X.shape[1])]
        # transform X into a dataframe (again)
        df = pd.DataFrame(X, columns=cols)
        # do we need to call transform?
        if not list(df.columns) == self.all_columns_:
            temp = self.always_return_numpy
            self.always_return_numpy = False
            df = self.transform(df)
            self.always_return_numpy = temp
        return self.prediction_model_.predict_proba(df[self.good_cols_].to_numpy())

I'll try to make proper PR in the coming week.

from autofeat.

mglowacki100 avatar mglowacki100 commented on May 28, 2024

Here is PR:
#38

from autofeat.

cod3licious avatar cod3licious commented on May 28, 2024

@mglowacki100 I've commented on your PR, it would be great if you could change the code accordingly!

from autofeat.

mglowacki100 avatar mglowacki100 commented on May 28, 2024

Hi @cod3licious,
Maybe, I miss something obvious but I don't see any comments/reviews for this PR :(

from autofeat.

mglowacki100 avatar mglowacki100 commented on May 28, 2024

@cod3licious I think 'Pending' status of review is misleading (https://github.com/orgs/community/discussions/10369)
On my side I see it like this:
autofeat_git

from autofeat.

cod3licious avatar cod3licious commented on May 28, 2024

@mglowacki100 you should now be able to install version 2.1.0 with the predict_proba function using pip install --upgrade autofeat - please let me know if there are any problems :)

from autofeat.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.