Comments (3)
Most welcome! It was very valuable to see you provide your vision on the DX 🎉
I totally agree with it. I think a more extensible file system would be like so:
@common
sides.ts
["Client", "Server", "UI"]messages.ts
["createRect", "sayHello", "ping"]
@side
message-transmitters.ts
Strategy registrar on how to transmit/send message to other sidesmessage-receivers.ts
Strategy registrar on how to receive/listen to message from other sidesmessage-handlers.ts
Behavior registrar on how to handle incoming messagesentry.ts
AppNetwork.initSide(AppNetwork.Sides.CLIENT, initTransmitters, initReceivers, initHandlers);feature.ts
AppNetwork.send(AppNetwork.Sides.UI, "createRect", { ... });
Not the actual implementation, but leaving @common
with only the backbones and a summary of what the whole network is
from figma-plugin-react-vite.
First of all, thank you so much for quick replying my question.
@common/netork
should only be there to;
- Define sides
- Define communication strategies
- Define which message are there
I absolute agree this. After solve this issue at monorepo-network
, I think it would be better to changes @common/network/init.ts, sides.ts
with specific logic location.
Current, there are not only what kind of Side exist but how attach and listen message(window.addEventListener("message", callback)
, figma.ui.on("message", callback)
) in @common
.
@common/network
just define what kind of sides(UI, PLUGIN) there. Then, specific code that how attach and listen message are located in each package(@ui
, @plugin
).
What do you think about it?
from figma-plugin-react-vite.
Hey there! 😁
Thanks for the great question/architectural issue you brought to the table 🎉
Comments on your cases
I think you have valid points, which makes the architecture a bit hard to extend. 😀
Let me try to give my comment on each situation you wrote down:
- Every message is under
@common/network/messages
. This was an idea heavily inspired by how Minecraft Forge's netcode works. Both sides can access it; one side uses it to be able to dispatch a "message sending" action, other side uses it to actually accommodate incoming "message" and handle it in some way. So handler in this case creates a two-way dependency on@common
and any other side. I find your word valuable on this. - Message depending on a utility/code specific to a side. This one a very good eye-opener for me. As I never considered in
monorepo-networker
there might be 2 completely isolated sides. I always had commonly available sides were a matter of subject. You are so right with this one! - Bringing in the handling code inside
@common
, even tho it's not a common code. Absolute the worst architectural design we could ever do, so you're absolutely right with this one as well.
What actions should be taken?
I think you made me see a crucial point of view, which I think Monorepo Networker should receive as a few updates:
- Message receive handlers are highly side-dependent. Therefore, they should be handled on their corresponding side. As you suggested ✅
@common/network
should only be there to;- Define sides - Which sides are available throughout the application ✅
- Define communication strategies - Which strategy a certain side uses to communicate with another side ✅
- Define which messages are there - Which messages are present for a certain side ✅
I'm actually going to create this as an issue in monorepo-networker
, to accommodate this very fundamental architectural problem.
Thanks a lot for enlightening me,
Feel free to share your thoughts 😁
from figma-plugin-react-vite.
Related Issues (3)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from figma-plugin-react-vite.