Giter Club home page Giter Club logo

Comments (17)

jess-edwards avatar jess-edwards commented on July 18, 2024

@jseldess agreed. Not mandatory for beta, but I'd like this done sooner than later. Should I put it on DivisionOf's radar?

from docs.

jseldess avatar jseldess commented on July 18, 2024

@jess-edwards: Yes, it'd be good to have them come up with a design. But if I understand right, we might need to change the search utility we use in order to control the look/feel of the results page. Ben mentions some options in PR #62.

from docs.

jess-edwards avatar jess-edwards commented on July 18, 2024

@jseldess Sounds good. I'll bring this up with DO once the website has launched.

from docs.

jess-edwards avatar jess-edwards commented on July 18, 2024

@jseldess @bdarnell @mjibson

I have a big concern that the current search implementation navigates you away from the website. Can that be fixed ASAP - preferably before docs launches?

from docs.

jseldess avatar jseldess commented on July 18, 2024

@jess-edwards, based on what @bdarnell said in PR #62, I think we'll have to move to Google's Custom Search Engine to be able to control the look and feel of the search results page.

There's a free version, but ads will show up. If we don't want ads (I'd prefer we exclude them), we'll have to pay: $100/year for 20,000 searches, $250/year for 50,000 searches, etc. Not sure what volume to expect, but we could probably start with the lowest.

@bdarnell, @spencerkimball: Should we just go with the lowest paid option? Or would you rather we look for a free alternative without ads, avoiding client-side search features for the reasons @mjibson mentions in PR #62?

from docs.

jess-edwards avatar jess-edwards commented on July 18, 2024

@jseldess paying for it sounds good to me. We can start with the $100 version and scale up accordingly. $100 seems pretty trivial for a great, ad-free product.

from docs.

jseldess avatar jseldess commented on July 18, 2024

Cool. I'll make sure this gets done for beta.

from docs.

bdarnell avatar bdarnell commented on July 18, 2024

@jess-edwards What exactly do you mean by "navigates you away from the website"? A google custom search engine is also "away from our website", although we retain some control over the presentation. I'm fine with paying for it if it works, but want to make sure it will actually solve the problem before we move further down this path.

If a CSE doesn't fit our needs, then I'd like to push back on doing anything about this pre-beta. The other solutions are a significant amount of work. (I think a client-side search is our next best bet. It's far from ideal but we're not big enough yet that the limitations are dealbreakers)

from docs.

mjibson avatar mjibson commented on July 18, 2024

I think the solution at http://www.aerospike.com/docs/ is exactly what we should do. It uses google to perform the search using a javascript request and displays the results in the documentation chrome. I think that'll meet everyone's requirements, and may not be too hard to do.

from docs.

jess-edwards avatar jess-edwards commented on July 18, 2024

@bdarnell I've attached screenshots for what I meant re: navigating away from our site. The first screenshot is what happens in our docs when you enter something into the search box. You leave the confines of our docs site and enter a google search window.

The second screenshot is how the search behaves happens when you enter something into aerospike's search box. The google search window is embedded within aerospike's docs site.

@mjibson Any idea how they did it?

screen shot 2016-03-03 at 9 43 10 am
screen shot 2016-03-03 at 9 42 53 am

from docs.

vivekmenezes avatar vivekmenezes commented on July 18, 2024

https://cse.google.com/cse/publicurl?cx=007743160730008282920:eqnepufhimm

I created a link to a custom search engine over the cockroach docs with ads.

They do offer an option to add this to your site through code.

On Thu, Mar 3, 2016 at 9:46 AM jess-edwards [email protected]
wrote:

@bdarnell https://github.com/bdarnell I've attached screenshots for
what I meant re: navigating away from our site. The first screenshot is
what happens in our docs when you enter something into the search box. You
leave the confines of our docs site and enter a google search window.

The second screenshot is how the search behaves happens when you enter
something into aerospike's search box. The google search window is embedded
within aerospike's docs site.

@mjibson https://github.com/mjibson Any idea how they did it?

[image: screen shot 2016-03-03 at 9 43 10 am]
https://cloud.githubusercontent.com/assets/6042450/13497637/7d564c34-e124-11e5-87b8-0e70ed1d40ec.png
[image: screen shot 2016-03-03 at 9 42 53 am]
https://cloud.githubusercontent.com/assets/6042450/13497638/7d5e6220-e124-11e5-9a1c-02f0f980544a.png

β€”
Reply to this email directly or view it on GitHub
#72 (comment).

from docs.

vivekmenezes avatar vivekmenezes commented on July 18, 2024

And we do go this path we should definitely turn off the ads. They are a
very big distraction from the content.

On Thu, Mar 3, 2016 at 10:01 AM Vivek Menezes [email protected]
wrote:

https://cse.google.com/cse/publicurl?cx=007743160730008282920:eqnepufhimm

I created a link to a custom search engine over the cockroach docs with
ads.

They do offer an option to add this to your site through code.

On Thu, Mar 3, 2016 at 9:46 AM jess-edwards [email protected]
wrote:

@bdarnell https://github.com/bdarnell I've attached screenshots for
what I meant re: navigating away from our site. The first screenshot is
what happens in our docs when you enter something into the search box. You
leave the confines of our docs site and enter a google search window.

The second screenshot is how the search behaves happens when you enter
something into aerospike's search box. The google search window is embedded
within aerospike's docs site.

@mjibson https://github.com/mjibson Any idea how they did it?

[image: screen shot 2016-03-03 at 9 43 10 am]
https://cloud.githubusercontent.com/assets/6042450/13497637/7d564c34-e124-11e5-87b8-0e70ed1d40ec.png
[image: screen shot 2016-03-03 at 9 42 53 am]
https://cloud.githubusercontent.com/assets/6042450/13497638/7d5e6220-e124-11e5-9a1c-02f0f980544a.png

β€”
Reply to this email directly or view it on GitHub
#72 (comment).

from docs.

mjibson avatar mjibson commented on July 18, 2024

@jess-edwards they are using the CSE API. I will work on a demo for this to see how feasible it is. I don't think it will be too difficult.

from docs.

jseldess avatar jseldess commented on July 18, 2024

So I purchased a year of custom google search for $100, plugged the custom search ID and api key into the js, and now we have search that stays in our docs site. Just go to cockroachlabs.com/docs and search to check it out. You might need to clear your cache (I did).

The h1 title of the page is only sometimes showing up in the search results. Anyone have any ideas about how we could improve that?

from docs.

bdarnell avatar bdarnell commented on July 18, 2024

The h1 "title" doesn't officially matter. The official HTML title of a page like https://www.cockroachlabs.com/docs/update.html is "Docs | Cockroach Labs". This is coming from _includes/head.html where the <title> tag always says "Docs". I think we just need to replace "Docs" with something like {{ page.title }} | {{ site.site_title }}. Note that it it will take some time for any changes to be reflected in the search results, but you can test changes here by looking at the title that is shown on your browser tab.

from docs.

spencerkimball avatar spencerkimball commented on July 18, 2024

Nice...search results are fast and look good.

On Mon, Mar 7, 2016 at 9:53 PM, jseldess [email protected] wrote:

So I purchased a year of custom google search for $100, plugged the custom
search ID and api key into the js, and now we have search that stays in our
docs site. Just go to cockroachlabs.com/docs and search to check it out.
You might need to clear your cache (I did).

The h1 title of the page is only sometimes showing up in the search
results. Anyone have any ideas about how we could improve that?

β€”
Reply to this email directly or view it on GitHub
#72 (comment).

from docs.

jseldess avatar jseldess commented on July 18, 2024

Thanks, @spencerkimball and @bdarnell.

Ben, I just updated _includes/head.html as you suggest. I think it should be working now. Please check PR #104.

from docs.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.