Feedback: Session Variables - does not mention disable_changefeed_replication about docs HOT 3 CLOSED

Shannon Bradshaw (shannonbradshaw) commented:
Kathryn May assigning to you just to make sure we’ve addressed this in the 24.1 release notes.

cc: Michael Lewis

from docs.

Kathryn May (kathancox) commented:
That session variable is listed on the session variable page. And there is further documentation here: https://www.cockroachlabs.com/docs/dev/changefeed-messages#filtering-changefeed-messages

This merged recently, so I think maybe this might have just been missed — unless I’m misunderstanding the ask here.

Checking the date this issue opened, I think we are safe to close the issue here. Feel free to reopen if I have missed something. PR for details: #18496

from docs.

Michael Lewis (mikeCRL) commented:
We happen to make reference to this in an item I have in the Key Cluster Setting Changes, copied from a release note from one of the 24.1.0 testing releases:

{{- The new boolean changefeed option ignore_disable_changefeed_replication, when set to true, prevents the changefeed from filtering events even if CDC filtering is configured via the disable_changefeed_replication session variable, sql.ttl.changefeed_replication.disabled cluster setting, or the ttl_disable_changefeed_replication table storage parameter. [#120255][#120255]}}

That said, I’m logging a task to consider whether we want to aggregate changes to session vars in a similar way to what we’ve been doing for cluster settings.

from docs.