schema: pause schema change job when running out of disk space about cockroach HOT 4 CLOSED

@fqazi - what do you think of the above approach? We should be able to expand this for other schema changes involving backfill as well right?

from cockroach.

I think its a reasonable approach, and I think was probably not there because it seems far less likely. We probably didn't expect the column backfill to balloon the size too much with an in place backfill.

from cockroach.

I think there is a very real possibility of column backfill leading to this scenario. In the legacy case, we will rewrite all the rows containing the new column which will easily 2x the table size until GC runs. With the declarative schema changer, we simply recreate the index so once again the space usage is high. I think this is worth prioritizing as it will at least prevent cluster outages due to the disk filling up.

from cockroach.

Let's add this check for the column backfiller here:

And also in the declarative schema changer here:

from cockroach.