Integratting Clippy about cobalt.rs HOT 7 CLOSED

Yes, good idea! Note that we have a setup in liquid-rust (at the top of lib.rs) that makes the build fail on nightly when certain rules are violated, for CI. It would be neat to have something like that in Cobalt as well, but we can also do that as a follow-up.

Thanks!

from cobalt.rs.

We actually use clippy in cobalt-org/liquid-rust so I don't see a reason we couldn't use it here. let's see what @johannhof says.

from cobalt.rs.

@achernyak did you get the chance to work on this yet? I'd love to see Clippy integrated as the code base grows :)

from cobalt.rs.

@johannhof I actually got this integrated, in a branch and was able to solve most the issues. However, the main building function needs a major refactor.

Maybe I could update it with the latest changes and push up what I have so we can discuss the best path forward.

from cobalt.rs.

Sounds good!

from cobalt.rs.

@achernyak any update on this? :)

from cobalt.rs.

Closed by 1c039da

from cobalt.rs.