unfubar strcat() in user_main.c about esp82xx HOT 5 CLOSED

Yeah, it seems some magic code, I didn't write has injected itself into the last merge. No idea what happened there (see the default conundrum).

But it seems strcat is not used anywhere in the code. @cnlohr can we just remove it? Why was it there in the first place and why not in one of our library files (i.e. ./esp82xx/include/string.h ) instead?

If we cannot remove it, what do you guys think of:

char * strcat( char * dest, char * src )
{
    char *orig = dest;
    while (*dest) dest++;
    while (*dest++ = *src++);
    return orig;
}

P.S.
What is charrx supposed to do?

from esp82xx.

I vaguely recall putting in the strcat code. Though I feel completely idiotic about writing it now. I don't know what I was thinking.

charrx I think is when data comes back down the serial line. That way you can easily hook incoming serial bytes.

from esp82xx.

P.S. Please use your code if you've tested it. I also noticed 'man cat' has an implementation:

           char *
           strncat(char *dest, const char *src, size_t n)
           {
               size_t dest_len = strlen(dest);
               size_t i;

               for (i = 0 ; i < n && src[i] != '\0' ; i++)
                   dest[dest_len + i] = src[i];
               dest[dest_len + i] = '\0';

               return dest;
           }

from esp82xx.

Fixed in 93074f1

from esp82xx.

and it works :-D

from esp82xx.