Giter Club home page Giter Club logo

Comments (5)

sushanthakumar avatar sushanthakumar commented on May 26, 2024

As per the current implementation we have, If "Annotation" is blank, it will select default_plugin.
Our expectation is like

  1. If "Annotation" is blank/not present, it should select default_plugin
  2. If "Annotation" is not blank and it is containing some non cni attributes (can be any standard pod things), it should still select default_plugin as no cni info provided
  3. If "cni" is not nil, it means plugin(s) provided in cni should be taken
  4. If cni ="" or cni annotation itself is not provided, then network annotation should be checked. If network is provided, it should be considered
  5. Finally (means cni=""), smart plugin should be selected

Currently Step 2 is not working as per the expectation, we can have an issue for this and fix this

from cni-genie.

sushanthakumar avatar sushanthakumar commented on May 26, 2024

If u guys have any doubts/concerns/suggestions, pls feel free to discuss here

from cni-genie.

lukaszo avatar lukaszo commented on May 26, 2024

Txh for clarification. Should I create a new issue for step 2?

from cni-genie.

sushanthakumar avatar sushanthakumar commented on May 26, 2024

Yes, u can create one

from cni-genie.

lukaszo avatar lukaszo commented on May 26, 2024

Actually it was easier to fix https://github.com/Huawei-PaaS/CNI-Genie/pull/102

from cni-genie.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.