Giter Club home page Giter Club logo

Comments (19)

AndreyKozlov1984 avatar AndreyKozlov1984 commented on August 16, 2024

Well, I'll have to take a look at that, certainly. We generate all pages during the build time, so the plan is to run a Chrome in the background, calculate the text size and make a word wrap if necessary.

from landscapeapp.

jmertic avatar jmertic commented on August 16, 2024

Hey @AndreyKozlov1984 - any updates on this?

from landscapeapp.

AndreyKozlov1984 avatar AndreyKozlov1984 commented on August 16, 2024

Ok, focusing on this task now

from landscapeapp.

AndreyKozlov1984 avatar AndreyKozlov1984 commented on August 16, 2024

@jmertic
image

I support the big_picture_label like : Early Adoption - Incubation, the rule is simple - if there are more than 20 symbols I make it 2 lines, now when it is multiline - if - is present in the label, I replace it with a new line, otherwise word wrap happens automatically

from landscapeapp.

jmertic avatar jmertic commented on August 16, 2024

Awesome - thank you @AndreyKozlov1984! That looks awesome!

Can you do something similar on the cards themselves?

from landscapeapp.

AndreyKozlov1984 avatar AndreyKozlov1984 commented on August 16, 2024

With cards it looks complicated, my best approach would be to treat ' - ' as a line break. If we can agree that multiline is triggered by the presence of ' - ' in the text and that is replace with a new line, then yeah, I can get it working

from landscapeapp.

AndreyKozlov1984 avatar AndreyKozlov1984 commented on August 16, 2024

On your screenshot it is basically not enough space, even for a multiline

from landscapeapp.

jmertic avatar jmertic commented on August 16, 2024

from landscapeapp.

jmertic avatar jmertic commented on August 16, 2024

On your screenshot it is basically not enough space, even for a multiline

Hmm - what other options do I have then? Could we have the badge two lines with line one the title and line two the text?

from landscapeapp.

jmertic avatar jmertic commented on August 16, 2024

Checking back in @AndreyKozlov1984 - seeing if you thought about my earlier comment and had any suggestions.

from landscapeapp.

AndreyKozlov1984 avatar AndreyKozlov1984 commented on August 16, 2024

Yes, multiline seems fine, I am a concerned with automatic detection of multiline, thus the label should somehow contain the information that we need to make it multiline. Maybe "!" or "..." or "-" on the end,

image

image

@jmertic That one is possible for this tag, just I need to have a clear way to see that multiline is necessary, like "-" in the text.
I thought about a total number of characters, but that seems to be unreliable.

from landscapeapp.

AndreyKozlov1984 avatar AndreyKozlov1984 commented on August 16, 2024

My proposal is that " - " in the value would mean we want a multiline. And, say, over 30 characters either in the name or in the value. Is this good ?

from landscapeapp.

jmertic avatar jmertic commented on August 16, 2024

Love it! Thanks @AndreyKozlov1984

from landscapeapp.

AndreyKozlov1984 avatar AndreyKozlov1984 commented on August 16, 2024

Ok, I am pushing the change at this moment, the criteria is over 30 characters or "-" in the value, works well for LF-Energy

I will ping you when this is deployed to production

from landscapeapp.

jmertic avatar jmertic commented on August 16, 2024

from landscapeapp.

AndreyKozlov1984 avatar AndreyKozlov1984 commented on August 16, 2024

Done!

image

from landscapeapp.

jmertic avatar jmertic commented on August 16, 2024

Awesome! I am seeing some alignment issues in my deploy preview below...

https://deploy-preview-565--lfenergy.netlify.app/?selected=carbon-data-specification-consortium-cdsc

Can you take a quick peek?

from landscapeapp.

AndreyKozlov1984 avatar AndreyKozlov1984 commented on August 16, 2024

Done, I have updated the landscapeapp.

from landscapeapp.

jmertic avatar jmertic commented on August 16, 2024

Awesome - thank you @AndreyKozlov1984 !

from landscapeapp.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.