Comments (8)
Hi Efe. The concern I had was that this info is written in our edm files. So we cannot know if someone is using or not. Technically, it is not relevant. Only this statement is true. That's why I like the solution of Sihyun, i.e. consider 1 or -1 as some default that is ok. Allowing again random numbers is not so great. We are just too many people to assure no one is using.
from genproductions.
Hi Alexander, yes, but following the same reasoning we could have kept the check. If something is used, we should check how it is used. I am sure that check was there for a reason...
from genproductions.
Hi so there are several things to think about here.
This creates somewhat unnecessary entropy for the MC contacts because
a. We don't know whether there are any real users for this metadata so we might be putting our efforts to something without real gain.
b. Removing the filter efficiency fragment still works (avoids gen checking script errors) - which means subset of the samples would for sure have broken filter efficiency written in GEN files as metadata. So subset of our samples are already broken.
c. It's not so easy to modify this through python scripts because efficiency from the run log (for filter efficiency) only gets delivered through email. I don't think the run log results are stored somewhere in McM, at least I am not aware. If I am correct, one needs to crop out the values from email boxes and tweak it into the fragments and I would hardly imagine MC contacts doing this. So in the end it would return to b. where MC contacts will just remove the line to avoid the problem, breaking the variables that should not be used.
But as Alexander said, SOME might use this and it MIGHT be not totally useless to store correct values. So allowing default settings (filter efficiency >= 1.0 or <=0.0 which doesn't make sense) is sort of compromise in between.
from genproductions.
Hi Efe,
maybe this was not clear in my message: I think we should have kept the check (and the motivation now is the same as back then: it is stored in EDM and we don't know if someone is using it or not) but just slightly modify it as proposed by Sihyun:
But as Alexander said, SOME might use this and it MIGHT be not totally useless to store correct values. So allowing default settings (filter efficiency >= 1.0 or <=0.0 which doesn't make sense) is sort of compromise in between.
Cheers, Alexander.
from genproductions.
Just to add a bit more
(filter efficiency >= 1.0 or <=0.0 which doesn't make sense)
This means that "filter efficiency itself doesn't make sense already and the users if they exist, they would know it's not trustable so they would avoid using it. but if it's some realistic value e.g. 0.48, people might believe the value is true and mistakenly use it if wrong values are stored."
So my proposal was, avoid checking unrealistic values BUT check realistic values to make sure people don't use them.
from genproductions.
OK, done. See #3280
from genproductions.
See the update: #3282
from genproductions.
Related Issues (20)
- Logic for creating gridpacks with 2016 PDFs HOT 5
- Problems with XML checking in PR #2571 HOT 4
- CMS Connect CODEGEN transfer methods broken
- Gridpacks, LO reweighting, and missing files HOT 5
- PDF variation list in Powheg HOT 2
- Small suggestion for request_fragment_check.py HOT 2
- cms-connect single job submit script HOT 6
- Madgraph Gridpack using loop_qcd_qed_sm model HOT 3
- genxanalyzer not giving results with negative cross sections HOT 1
- Compilation Issues with reweight MG265 and SMEFTsim LO (master) HOT 10
- Large gridpack fails with non zero status 137 HOT 2
- GridPack Generation fail on CMSConnect HOT 4
- MadGraph patch for 29x : color flow HOT 4
- MadGraph tarballs on cvmfs HOT 4
- CPX Tune Import Path for Run3 fragments HOT 1
- adding MG version 3.5 HOT 25
- Track CMS changes to MG5 source via git repository instead of patch files HOT 5
- Compilation issue when generating the diphotonJets gridpack HOT 8
- cleaning up the unneeded files in madgraph HOT 6
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from genproductions.