Comments (3)
I will go for the second option. Can you make a PR with the code change and the test that proves your issue gets fixed?
from netdumbster.
Sure! I'll send it over later today.
from netdumbster.
Okay so ran the test and debugging, it seems I confirmed my suspicions: SmtpMessage
on line 30
:
rawMessage = rawMessage.Substring(0, rawMessage.Length - 4);
If I'm not mistaken this is to remove the carriage return from the raw message, so the body can be "extracted".
Instead, why not just do: rawMessage.TrimEnd()
or rawMessage.TrimEnd('\r', '\n');
? Should be safer I guess. Did in a local fork and all tests seem to pass.
from netdumbster.
Related Issues (20)
- Support simpler SMTP transaction HOT 2
- TCPListener keeps socket open HOT 2
- Ensure proper cleanup of connections on server stopping HOT 12
- TLS Not supported HOT 3
- SimpleSmtpServer.Start is not checking if port is in use HOT 2
- HeaderData has ASCII encoding HOT 9
- FileLoadException: something about MimeKit not being loaded HOT 14
- Some tests fail when running in unix environments HOT 2
- Reusing SmtpClient hangs in net50 HOT 13
- Tests with netdumbster fail on github action HOT 8
- c# - how to get email Subject? HOT 4
- Stopping connection mid message closes TCP Listener HOT 2
- The SMTP server does not support authentication HOT 2
- Make Start(Configuration configuration) public HOT 2
- SmtpMessagePart.HeaderData does not contain all headers
- SMTP server with basic authentication HOT 1
- Set Licence type expression on package info
- Use a package readme
- Body Encode issue
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from netdumbster.