Comments (3)
They all add up, and it's not so much about the size but the complexity of dependencies. Deno provides a very simple way to keep a dependency tree as clean as possible, by importing only exactly what you absolutely require, we should embrace it, it's the main advantage over the npm dependency hell.
If want to write functions that reference the OAuth2ClientConfig type, then I want just that, and not the whole implementation, and there is no reason I shouldn't be able to do that if types are just exported separated, it's a pretty easy thing for a library to do, and doesn't break compatibility.
from deno-oauth2-client.
This is a server-side module. A server downloading the whole module of 33 KB is negligible. This would be a different story if this were a client-side module where dependency sizes have a tangible effect. While this would be nice to have, this is not something to be concerned about.
from deno-oauth2-client.
Sounds reasonable
I'll add this change to the PR with the OIDC implementation (#39), since it already includes a refactoring of the OAuth2Client
class.
from deno-oauth2-client.
Related Issues (20)
- CI: run deno lint
- Implement Refresh Token Grant
- Deno.HttpClient HOT 3
- How do I check whether user is authorized to access protected page? HOT 7
- Examples broken - the JSON entry 'name' changed to 'login' HOT 3
- Fail with better error message when the access token cannot be retrieved HOT 3
- Scope is not always a string HOT 3
- id_token support (OpenID) HOT 3
- suggestion: `getUserInfo()` HOT 15
- suggestion: support token revocation HOT 1
- question: how to handle expired refresh token? HOT 5
- Using this with Auth0 HOT 3
- OAuth2Strategy requires a clientID option HOT 2
- Add support for Cheetah framework
- Question: what if `token_type` is not always available HOT 4
- Token expires_in returned from auth server as string
- suggestion: remove `OAuth2ClientConfig.defaults`
- suggestion: use code coverage tool
- suggestion: publish to JSR
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from deno-oauth2-client.