Giter Club home page Giter Club logo

Comments (3)

jollytoad avatar jollytoad commented on September 20, 2024 1

They all add up, and it's not so much about the size but the complexity of dependencies. Deno provides a very simple way to keep a dependency tree as clean as possible, by importing only exactly what you absolutely require, we should embrace it, it's the main advantage over the npm dependency hell.

If want to write functions that reference the OAuth2ClientConfig type, then I want just that, and not the whole implementation, and there is no reason I shouldn't be able to do that if types are just exported separated, it's a pretty easy thing for a library to do, and doesn't break compatibility.

from deno-oauth2-client.

iuioiua avatar iuioiua commented on September 20, 2024

This is a server-side module. A server downloading the whole module of 33 KB is negligible. This would be a different story if this were a client-side module where dependency sizes have a tangible effect. While this would be nice to have, this is not something to be concerned about.

from deno-oauth2-client.

cmd-johnson avatar cmd-johnson commented on September 20, 2024

Sounds reasonable

I'll add this change to the PR with the OIDC implementation (#39), since it already includes a refactoring of the OAuth2Client class.

from deno-oauth2-client.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.