Using with travis about boost-lib HOT 15 CLOSED

Cool. I'll release master later today.

from boost-lib.

Could you try it by inserting the following before this line: https://github.com/cmake-js/boost-lib/blob/master/cmake/BoostLib.cmake#L20

set(Boost_FOUND true)

from boost-lib.

No luck: https://travis-ci.org/lyssdod/node-libtorrent/jobs/161431705#L901
My patch: https://github.com/lyssdod/node-libtorrent/blob/master/boostlib.patch

from boost-lib.

Well, I'm groping in the dark there. I believe find_package https://github.com/cmake-js/boost-lib/blob/master/cmake/BoostLib.cmake#L13 sets its values to cache as forced, and somehow it prevents our values propagate to the upper scope https://github.com/cmake-js/boost-lib/blob/master/cmake/BoostLib.cmake#L27. Cannot reproduce but this is the most obvious cause. Exactly like this SO issue: http://stackoverflow.com/questions/5006286/cmake-set-doesnt-work-on-same-variable-after-find-path-was-called

Anyway I believe changing https://github.com/cmake-js/boost-lib/blob/master/cmake/BoostLib.cmake#L27 to this code:

set(Boost_FOUND ${Boost_FOUND} CACHE BOOLEAN "" FORCE)
set(Boost_INCLUDE_DIRS "${Boost_INCLUDE_DIRS}" CACHE STRING "" FORCE)
set(Boost_LIBRARIES "${Boost_LIBRARIES}" CACHE STRING "" FORCE)

Will resolve this issue. Could you try this at your side? Thanks.

from boost-lib.

@unbornchikken Unfortunately no luck also: https://travis-ci.org/lyssdod/node-libtorrent/jobs/161995682#L905

I've tried both the last variant and combined patch — it still can not find boost

from boost-lib.

Could you try with master? Gotta work that way.

from boost-lib.

Hi, I've tried but got another error: https://travis-ci.org/lyssdod/node-libtorrent/jobs/162096387#L1032
It looks like this is caused by Travis incorrectly setting environmental variables regarding new compiler. I'll try with Trusty image which (as they say) contains newer toolchain.

from boost-lib.

Unfortunately, using trusty didn't solve the problem: https://travis-ci.org/lyssdod/node-libtorrent/jobs/162097341#L902. How do you think, can it be connected to recent merge regarding setting ToolSetVer for boost?

from boost-lib.

At least we have made progress. I'm thinking on the next step. We need a smarter toolchain detection for sure. Dunno how did we captured three part version for gcc though. That should be two part one.

from boost-lib.

Next round in master. Please give it a try.

from boost-lib.

Yeah, the progress is definitely made 👍

For now it passed the build of boost itself, but stopped complaining about missing headers, though different on Linux and OSX:

https://travis-ci.org/lyssdod/node-libtorrent/jobs/162157466#L865
https://travis-ci.org/lyssdod/node-libtorrent/jobs/162157467#L843

I've opened an issue about that in libtorrent repo and they said it can be a boost installation problem:
arvidn/libtorrent#1121

from boost-lib.

Well, according to the logs, it does download and extracts functional headers, and include paths are set for sure, because there is only one include path for whole boost. Do you have home folder access for Travis? Or is this issue reproducible on Linux at your side? I don't have access to a dev machine until late evening to try out your stuff.

from boost-lib.

I've made a listing and header is there, at least for OSX: https://travis-ci.org/lyssdod/node-libtorrent/jobs/162172605#L1062

I can't reproduce it on my side (got it working on ubuntu 16.04 and gentoo), it happens only on Travis for some reason

from boost-lib.

Failed header for Linux is also in place: https://travis-ci.org/lyssdod/node-libtorrent/jobs/162185696#L1270

from boost-lib.

Hi, it turned out on the recent build it was my fault — I had to specify boost headers explicitly (somehow I thinked cmake-js will pick them up for me) and now everything is working. Thank you very much!

from boost-lib.