Comments (3)
Hi! I've proposed a solution
from ha_cluster_exporter.
@mbiagetti Thanks for your collaboration!
@MalloZup I am not against on having code coverage included and enforced on the CI, not as a punishment tool, but as a tool to help us to grow the codebase without introducing regressions that often. Not saying that unit tests will cover everything or so, but many times the fact that you need to write tests makes you double check some parts and even refactor to a better code before even submitting a PR. My vote would be to have it checked on each PR and as much as possible have it covered. On special cases, we can overwrite the check if need.
from ha_cluster_exporter.
@diegoakechi ok we can have it as long it doesn't write comments to PR or block them i'm fine
from ha_cluster_exporter.
Related Issues (20)
- research about addition of codeql
- Node atttributes and Systemd units data not showing up in Grafana HOT 4
- No data from the dashboard
- Issue with `ha_cluster_pacemaker_config_last_change` and timezone HOT 1
- corosync parser error: could not parse node id in corosync-quorumtool output: could not find Node ID line HOT 23
- Compress binaries attached to GH releases
- Error when disabled all cluster nodes HOT 7
- sbd data is not exported if devices in SBD_DEVICE have an space after ;
- Support SSL/TLS connections HOT 1
- Sample Prometheus alerting rules HOT 1
- Pacemaker metrics not available for monitoring HOT 1
- Not able to install Latest 1.3.0 version for prometheus-ha_cluster_exporter HOT 4
- HA Cluster configuration sample is erroneous HOT 2
- regexp parsing corosync-cfgtool output will not work HOT 2
- get trouble with make && make install
- get trouble with start exporter HOT 1
- wrong default web-config file HOT 1
- No instance id inside export metrics HOT 1
- Dockerized ha_cluster_exporter: Missing Metrics and Collector Initialization Issues HOT 1
- Running as non-root user HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ha_cluster_exporter.