Giter Club home page Giter Club logo

Comments (3)

mbiagetti avatar mbiagetti commented on June 21, 2024

Hi! I've proposed a solution

from ha_cluster_exporter.

diegoakechi avatar diegoakechi commented on June 21, 2024

@mbiagetti Thanks for your collaboration!

@MalloZup I am not against on having code coverage included and enforced on the CI, not as a punishment tool, but as a tool to help us to grow the codebase without introducing regressions that often. Not saying that unit tests will cover everything or so, but many times the fact that you need to write tests makes you double check some parts and even refactor to a better code before even submitting a PR. My vote would be to have it checked on each PR and as much as possible have it covered. On special cases, we can overwrite the check if need.

from ha_cluster_exporter.

MalloZup avatar MalloZup commented on June 21, 2024

@diegoakechi ok we can have it as long it doesn't write comments to PR or block them i'm fine

from ha_cluster_exporter.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.