Builtin cosine_similarity about adamp HOT 4 CLOSED

Also, curious why your cosine similarity has an absolute value, I scanned the paper but it wasn't immediately obvious...

from adamp.

Hi

There is no special reason to use self defined cosine sim
I just couldn't think of PyTorch cosine similarity.
I will replace it in the next code release.

I missed the absolute value operation in the paper and it is a mistake.
In if statement of eq (11), we want to check whether the cosine similarity is close to zero or not.
So, it should be

I will change it in the next ArXiv version

Thanks for the valuable advices.

from adamp.

Cosine similarity is changed to built-in operation in #7.
Thanks for your contribution.

from adamp.

@rwightman
The fixed version is just released as adamp==0.3.0(https://github.com/clovaai/AdamP/releases/tag/v0.3.0).
Thanks for your contribution again!

from adamp.