Giter Club home page Giter Club logo

Comments (2)

AlistairDoswald avatar AlistairDoswald commented on July 25, 2024

From the user documentation, the first broker login flow is the correct first flow, as keycloak needs to create information for the user locally, and a link to the user in the external IdP, so the "browser" login flow shouldn't be investigated.

Now, for the first broker login flow, the problem is that when the username or Id is null, keycloak cannot create the link to the external IdP user due to the fields being null. The pull request from @SebZal corrects the Id problem, but not the username problem. Even through this can be avoided by configuring the client correctly in the IdP, the following steps will be taken:

  • Make the getUsername() method return getId() if it can't get a name rather then the opposite. This will bring it in line for what is done for SAML2 tokens.
  • Have the WSFedEndpoint handleLoginResponse method throw an exception if the Id or Username is null rather than waiting to get a NullPointerException to happen when keycloak tries to create the user's Identity Provider link.
  • Write the unit tests for the SAML11RequestedToken class since there doesn't seem to be any :-p

from keycloak-wsfed.

AlistairDoswald avatar AlistairDoswald commented on July 25, 2024

Modifications done and tested

from keycloak-wsfed.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.