Giter Club home page Giter Club logo

Comments (5)

just-boris avatar just-boris commented on May 27, 2024

If we start looking into this issue, we should support it for all components, not just dropdown. How do you expect this to work? How do we distinguish "good" i18n strings (which should follow your selector) and "bad" (which should not)?

Can you make your * selector more specific to strings that you certainly know should have this wrapping?

from components.

franky920920 avatar franky920920 commented on May 27, 2024

Hi @just-boris,
(Found typo in issue, edited)

I expect all components has its own css property instead of inheriting from its parent.

In my use case, our i18n strings may contains \n characters to determinate line break in different languages, like the example below:

// en/translation.json
{
  "demo_string": "This is a long line of description and requires \n link breaks."
}

If we don't have white-space: break-spaces; set, the \n for line break won't work like expected, but one its set, it might break Cloudscape component like ButtonDropdown here:

unexpected

image

expected

image

from components.

just-boris avatar just-boris commented on May 27, 2024

So if you put a <Header description={i18nStrings.demo_string}> you expect this to respect line breaks. But if you put the very same string inside <ButtonDropdown items={[{text: i18nStrings.demo_string}]}> you expect line breaks to be ignored.

How do you make sense of this request?

from components.

franky920920 avatar franky920920 commented on May 27, 2024

Sorry I think my previous description were not clear, so let me clear this again.

Assuming I have a translation file like this:

{
  "string_for_box": "This is a long line of description and requires \n link breaks.",
  "string_for_actionButton": "Actions",
  "string_for_actionButton_a": "This is a long item without line break"
}

For <Box>{i18n.string_for_box}</Box>, I DO expect a line break here as I put a \n in i18n strings indicating I want a line wrap, so I put white-space: break-spaces styles on * selector to make \n break the lines.

But for

<ButtonDropdown item={[text: i18n.string_for_actionButton_a]}>
  i18n.string_for_actionButton
</Box>

I DO NOT expect any string being wrapped like this screenshot as I didn't put any \n in these strings.
image

Hope this make the issue clear. Sorry for the bad description previously.

from components.

just-boris avatar just-boris commented on May 27, 2024

So you want <Box> component to wrap and <ButtonDropdown> not to wrap.

What should we do if tomorrow we get another customer requesting the exact opposite behavior? How are we supposed to support both cases?

from components.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.