aws_elasticache_parameter_group should have create_before_destroy set to `true` about terraform-aws-elasticache-redis HOT 7 CLOSED

As is, this bug prevents using this module for major version upgrades.

from terraform-aws-elasticache-redis.

I have a PR open to fix this, but it has a bug and I haven't had the time to fix it yet. Will try to look at it soon.

#189

from terraform-aws-elasticache-redis.

Any thoughts when this will be fixed?

from terraform-aws-elasticache-redis.

Maybe it can be fixed by adding depends_on block?

from terraform-aws-elasticache-redis.

I believe the fix would be to add some random suffix so it creates a new param group name. This would force the creation of a new param group, move the cluster to the new param group and remove the old one. Like @joshuabaird said, this prevents major version upgrades as the family variable forces the param group to be recreated.

from terraform-aws-elasticache-redis.

It's actually a bit more complicated than just setting create_before_destroy. The parameter group name doesn't have the version name, so it will fail if create_before_destroy is set because it cannot create a new group with the same name.

from terraform-aws-elasticache-redis.

@joshuabaird @sherifkayad @evanstachowiak I fixed this in my own instance of the cloudposse code by making the replication group depend_on the param group. That way the create order is param group then replication group, and a destroy etc is the inverse

from terraform-aws-elasticache-redis.