Giter Club home page Giter Club logo

Comments (3)

ixti avatar ixti commented on July 3, 2024

As this feature will include expansive RegExp work, I believe this must be implemented as "pluggable" option, e.g.:

set :utf8, true

So this will enable extra-worker for those who write non-ascii blogs :))

The second thing I guess we need to agree is how we are going to work with such titles. The easiest way is to implement one-way conversion, e.g. files would be in ascii format, like: 2011-08-13-proverka.txt, while titles will allow non-ascii chars without any problems, e.g. проверка. This way is easy, but looks more like a workround, so the best behavior (I believe) is to allow two-way conversion, so URL /2011/08/13/proverka will try to get file 2011-08-13-проверка.txt and then 2011-08-13-proverka.txt

from toto.

sorin-ionescu avatar sorin-ionescu commented on July 3, 2024

I also have this problem. It returns 404 because it cannot find articles with non ASCII characters in the title since the slugize method removes them, and def path at line 274 returns the slug. We have to deslug the path in def go.

from toto.

sorin-ionescu avatar sorin-ionescu commented on July 3, 2024

Something like bellow should work.

def article route
  path = self.articles.select do |article|
    File.basename(article, ".#{self[:ext]}").slugize.eql? route.join('-')
  end.last || File.join(Paths[:articles], "#{route.join('-')}.#{self[:ext]}")
  Article.new(path, @config).load
end

Unfortunately, there is an encoding issue. File.basename(article, ".#{self[:ext]}").slugize fails to equal route.join('-') in certain cases. Even though the string can look identical to the eye, slugize can generates different slugs.

from toto.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.