Comments (5)
One alternative to explore: can we only handle creation and then make the label immutable?
The Default()
method does not know whether a resource is being created or updated, and there is no way to raise an error, so we chose to always set the appGuid
label to the value of the metadata.name
field. There does not appear to be a way to make a set of labels immutable.
from korifi.
It seems likely that we'll need https://github.com/open-policy-agent/gatekeeper, or similar, to disallow changes to parts of some resources based on role.
If you find you need immutable labels, that should be simple enough to set up as an OPA rule.
from korifi.
Yes, labels are not immutable and are not expected to be.
Should the sample resource have the label now deleted since the mutating webhook now creates it?
Otherwise everything looks good to me.
from korifi.
@angelachin Thats a good catch. Have addressed it in this PR
from korifi.
Awesome, looks good to me. Seems like this issue can be closed out.
from korifi.
Related Issues (20)
- [Feature]: As a Korifi app developer I want to see the MEMORY_LIMIT environment variable in my app containers HOT 2
- As a Korifi user I want to see the app status as "crashed" when my app exits
- As a Korifi user I do not want my application to restart when I bind/unbind a service instance to it HOT 5
- CFApp controller should not manage VCAP_SERVICES HOT 1
- CFApp controller should reuse servicebinding.io capabilities to project the VCAP_APPLICATION env var to the app workload HOT 1
- Replace servicebinding.io duck types with direct secret reference HOT 1
- Revisit usages of secret.StringData
- As a Korifi kubectl user I want my service binding to go to a Failed state when I try to chage its credential type
- [Feature]: As a Korifi user, my annotations and labels appear on the StatefulSet
- Monitor app health during Korifi upgrade HOT 1
- Korifi installation on single namespace HOT 3
- upgrade or re-install steps for new version HOT 4
- Disabling cert manager dependency as part of helm install HOT 1
- Deploy Spring music on acceptance
- Remove the 'statefulsetRunnerTemporarySetPodSeccompProfile' and 'jobTaskRunnerTemporarySetPodSeccompProfile' flags
- Push app env var related code into the env builder
- As a Korifi API user I do not want to see a "type" field in my user provided serivce details in VCAP_SERVICES
- [Bug]: Application is crashing and getting the permission denied after deploying the DotNet app. HOT 7
- Gateway object for korifi api uses protocol mode passthrough with TLS Protocol. Looks like Nginx gateway fabric does not support TLS protocol and passthrough? HOT 2
- Track kpack PR https://github.com/buildpacks-community/kpack/pull/1562
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from korifi.