Exception while deploying Spring Boot app with liberty buildpack about ibm-websphere-liberty-buildpack HOT 12 CLOSED

This looks like it might have been fixed in commit 1eef9e9. Could you confirm?

from ibm-websphere-liberty-buildpack.

Tom, I'm pretty sure that's a different problem. In this case the app was deployed successfully and that error appeared in the log. While without the 1eef9e9 fix the app would not even deploy.

from ibm-websphere-liberty-buildpack.

Jarek, I'm not sure I'm following. This issue was raised a few weeks before that commit. How could the app have successfully deployed?

I've just tried pushing the application and have been unable to reproduce the problem.

from ibm-websphere-liberty-buildpack.

Sorry, I was trying to say the there are two separate problems related to Spring. 1eef9e9 fixed one problem but the problem in this issue is differnet. The problem in this issue is that the application got deployed OK but there is an error in the log while it's running (looks like a spring autoconfiguration problem). The problem that I fixed was a case where the application wouldn't even deploy. That was a problem a problem in the detect scripts.

from ibm-websphere-liberty-buildpack.

Do you still need me to test or are you satisfied this is a separate issue?

from ibm-websphere-liberty-buildpack.

Can you send the app or point us to it?

from ibm-websphere-liberty-buildpack.

I provided a war to @ThomWright earlier today.

from ibm-websphere-liberty-buildpack.

Ryan and Jarek,

I'm still trying to understand what the problem is here. This is what I understand so far:

The .war has a 'Main-Class' entry in the MANIFEST.MF file. Now, with Jarek's changes, the Liberty buildpack runs the app as if it was a .jar. It then runs on the embedded instance of Tomcat. This works fine.

From what I understand, the app has also been packaged without the 'Main-Class' entry in the manifest, so the buildpack will run the app as a .war on the Liberty Profile server. This is when the problem occurs.

Please correct me if I've misunderstood.

I've tried running the app sans the 'Main-Class' in the manifest on both the Liberty and Java buildpacks. I saw exceptions on both. Neither matched the exception in this issue. Is there something else I should be doing to reproduce this?

from ibm-websphere-liberty-buildpack.

Tom,

Interesting. Could you try deploying this application with buildpack code at revision before the fix for Main-Class went it? Maybe it was taken care of by the Main-Class fix but I'm not convinced yet.

Ryan,

Are you able to still reproduce the problem on your end?

from ibm-websphere-liberty-buildpack.

@jgawor I just got back to trying this and it is working now if I specify the url to the buildpack. If I just push the war without specifying the buildpack Bluemix chooses to use the CF Java buildpack as oppose to using Liberty, but that doesn't seem to be a buildpack problem.

from ibm-websphere-liberty-buildpack.

Getting back to this... I was able to test this issue with the original application. The application was .war file with META-INF/MANIFEST.MF with Main-Class attribute set. I was unable to replicate the original problem (Failed to access resource) but I do see the same behavour as @ryanjbaxter where the Java buildpack picks up this application. That is happening becuase the Liberty buildpack detect method returned "Application can not be run by more than one container" type of error and Cloud Foundry continued to look for other buildpacks that can handle this type of application. In which case, the Java buildpack picked it up next and things deployed fine.
The 1eef9e9 fix addresses the "Application can not be run by more than one container" error and therefore, next time when this type of application is deployed, the Liberty buildpack should pick it up instead of the Java buildpack.

from ibm-websphere-liberty-buildpack.

Closing this issue as the core problem should be fixed now.

from ibm-websphere-liberty-buildpack.