Falling back to single-page application 404 page for static assets about kv-asset-handler HOT 2 CLOSED

Thanks for the question! I'm not entirely sure about spreading event, but I think you should be able to refactor this by just modifying the napRequestToAsset function on your second call to getAssetFromKV, such as this (untested):

async function handleEvent(event){
	let options = {
		mapRequestToAsset: serveSinglePageApp,
	};

	let page;
	try{
		page = await getAssetFromKV(event, options);
	}catch(err){
		if(err instanceof NotFoundError){
			// Continue and let the SPA show its 404 page
			page = await getAssetFromKV(event, {
				mapRequestToAsset: (request) => {
					const {origin} = new URL(event.request.url);
					const newRequest = new Request(`${origin}/index.html`, request);
					return newRequest;
				},
			});
		}else{
			throw err;
		}
	}

	const response = new Response(page.body, page);
	// <snip> Set some response headers...
	return response;
}

This makes use of a custom mapRequestToAsset function, overriding the request key to your specific index.html on a NotFoundError, which appears to be what you're trying to do in your catch block, and is the recommended way to modify the requestKey today. You may want to modify the response status code to be a 404 too, such as in the example template.

from kv-asset-handler.

Thanks @Cherry -- using a custom mapRequestToAsset function works nicely! I appreciate the help.

from kv-asset-handler.