Remove "Fun" Functions about sdk-javascript HOT 5 CLOSED

+1

from sdk-javascript.

I agree that a file full of utility functions can be a code smell. But I generally prefer to keep dependencies as minimal as possible. What's the benefit of removing this code that already exists and works and replacing it with a dependency?

from sdk-javascript.

What's the benefit of removing this code that already exists and works and replacing it with a dependency?

The less code we have to maintain the faster we can progress with testing, refactoring, updating etc. We have a lot of code that is not needed. There are a lot of reasons to use libraries and simplify functions.

I think the reality is that we'll include one dependency for type validation and remove all the unused code.

from sdk-javascript.

The less code we have to maintain the faster we can progress with testing, refactoring, updating etc.

I generally agree that less is more. I'm just saying that this works, it's 1/30 the size of the is module, and I haven't seen any indication that maintaining this single file is problematic for our velocity. To me, switching to is seems arbitrary, bloats the install size of the module, and doesn't really buy us anything.

from sdk-javascript.

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days

from sdk-javascript.