Comments (6)
I think this will be resolved with #78
: It was resolved
from sdk-javascript.
Hi, can we please keep the issue open until we're sure the issue is fixed? Did we test that this is fixed?
I'm still seeing the issue.
Here is trace from a test I ran after the PR merged:
> [email protected] coverage-publish /home/travis/build/cloudevents/sdk-javascript
> wget -qO - https://coverage.codacy.com/get.sh | sh -s report -l JavaScript -r coverage/lcov.info
sh: 3: set: Illegal option -o pipefail
npm ERR! code ELIFECYCLE
npm ERR! errno 2
npm ERR! [email protected] coverage-publish: `wget -qO - https://coverage.codacy.com/get.sh | sh -s report -l JavaScript -r coverage/lcov.info`
npm ERR! Exit status 2
npm ERR!
npm ERR! Failed at the [email protected] coverage-publish script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
npm ERR! A complete log of this run can be found in:
npm ERR! /home/travis/.npm/_logs/2020-04-29T16_16_53_094Z-debug.log
The command "if [ "$TRAVIS_PULL_REQUEST" == "false" ]; then npm run coverage-publish; else npm test; fi" exited with 2.
cache.2
store build cache
from sdk-javascript.
Not sure where that failure is happening now. Can you link to it? All of the recent CI runs for pull requests are passing: https://travis-ci.org/github/cloudevents/sdk-javascript/pull_requests
And the CI run for #78 passed: https://travis-ci.org/github/cloudevents/sdk-javascript/builds/681089567.
And current master
passes: https://travis-ci.org/github/cloudevents/sdk-javascript/builds/681087308
It seems the failure is only happening on your branches. Maybe you haven't pulled that commit in yet?
Also - I'm curious... Why are you creating fix branches on upstream and not on your own fork?
from sdk-javascript.
Also - I'm curious... Why are you creating fix branches on upstream and not on your own fork?
This also makes me wonder if it really makes sense for the Travis-CI configuration to build all branches. Perhaps it should be configured to build only from master
and any release branches. (Speaking of... it would probably make sense to create release branches).
https://travis-ci.org/github/cloudevents/sdk-javascript/branches
from sdk-javascript.
@grant - looks like you got the CI issues worked out. OK to close this now?
from sdk-javascript.
Looks like it's been fixed and the signing issue isn't a problem anymore. Fixed on master
. Thanks for checking. Closing.
from sdk-javascript.
Related Issues (20)
- Binary mode header missing extension attribute when the value is false (boolean)
- Validation is broken HOT 1
- Issue converting a golang cloudevents type Kafka message HOT 3
- Unnecessary polyfill for http and https required HOT 3
- Harmonize validation of CloudEvents HOT 9
- Avoid jest#13535 and planttheidea/fast-equals#91
- [security] Potential XSS in httpTransport() HOT 3
- Does not work in browsers as of 5.3.1 HOT 1
- Add the engines property to the package.json HOT 1
- Add Tests for the Browser version HOT 2
- No .d.ts files available for browser bundle HOT 1
- Add Test Runner for Node 18 LTS HOT 1
- Can't resolve 'http' error when using on React app HOT 11
- Vulnerability of util version 0.12.5 HOT 2
- Invalid default data for parsing in binary mode HOT 7
- Getting error when installing on node 20.0.0
- Compatible with Node 20.x HOT 1
- Add support for request timeout in HTTP transport HOT 2
- HTTP headers name case for extensions HOT 3
- Unable to retrieve data from the HTTP request HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from sdk-javascript.