Giter Club home page Giter Club logo

Comments (10)

msecret avatar msecret commented on July 29, 2024 1

It's actually here: https://github.com/18F/cg-style/blob/master/documentation/frontend_standards.md

from cg-dashboard.

jeremiak avatar jeremiak commented on July 29, 2024

Adding to the backlog because we're looking for a linter that isn't ruby based

from cg-dashboard.

jeremiak avatar jeremiak commented on July 29, 2024

We have a few options for JS based linters.

sass-lint looks pretty compelling, especially since it has a built in scss-lint config converter which could aid in the transition.

There is also a PostCSS-based tool (which doesn't support sass) called stylelint that we could use as a CSS linter but might not be the best option since it:

  1. does not support Sass
  2. diverges from the 18F front end guild guidelines since the configs are not compatible.

from cg-dashboard.

msecret avatar msecret commented on July 29, 2024

We're going to go with stylelint. It does support sass, and we're working on a config for 18F by adding some postcss plugins.

from cg-dashboard.

msecret avatar msecret commented on July 29, 2024

Sorry, wrote that before reading your answer.

Why isn't styelint compatible with scss?

from cg-dashboard.

msecret avatar msecret commented on July 29, 2024

Ended up picking this up because it coincided with a task I had to do for the front end guild and because it will be nice to have with more people working on the cg-style codebase.

from cg-dashboard.

jeremiak avatar jeremiak commented on July 29, 2024

I'm going to evaluate the acceptance criteria against the style guide repo because of cloud-gov/cg-style#83

from cg-dashboard.

jeremiak avatar jeremiak commented on July 29, 2024

@msecret this looks almost done. The last criteria is:

A developer should be able to find what CSS style guide is the standard in the CONTRIBUTING document.

from cg-dashboard.

msecret avatar msecret commented on July 29, 2024

Good call, will add now.

from cg-dashboard.

jeremiak avatar jeremiak commented on July 29, 2024

We don't have a CONTRIBUTING doc in 18f/cg-style (so that's bad acceptance criteria) but the style guide/linting information is there.

from cg-dashboard.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.