Comments (10)
It's actually here: https://github.com/18F/cg-style/blob/master/documentation/frontend_standards.md
from cg-dashboard.
Adding to the backlog because we're looking for a linter that isn't ruby based
from cg-dashboard.
We have a few options for JS based linters.
sass-lint
looks pretty compelling, especially since it has a built in scss-lint
config converter which could aid in the transition.
There is also a PostCSS-based tool (which doesn't support sass) called stylelint
that we could use as a CSS linter but might not be the best option since it:
- does not support Sass
- diverges from the 18F front end guild guidelines since the configs are not compatible.
from cg-dashboard.
We're going to go with stylelint
. It does support sass, and we're working on a config for 18F by adding some postcss plugins.
from cg-dashboard.
Sorry, wrote that before reading your answer.
Why isn't styelint compatible with scss?
from cg-dashboard.
Ended up picking this up because it coincided with a task I had to do for the front end guild and because it will be nice to have with more people working on the cg-style codebase.
from cg-dashboard.
I'm going to evaluate the acceptance criteria against the style guide repo because of cloud-gov/cg-style#83
from cg-dashboard.
@msecret this looks almost done. The last criteria is:
A developer should be able to find what CSS style guide is the standard in the CONTRIBUTING document.
from cg-dashboard.
Good call, will add now.
from cg-dashboard.
We don't have a CONTRIBUTING
doc in 18f/cg-style (so that's bad acceptance criteria) but the style guide/linting information is there.
from cg-dashboard.
Related Issues (20)
- Proposal: use arrow property initializer functions in classes (e.g. f = () => {})
- Proposal: change NODE_ENV=prod to conventional NODE_ENV=production
- Upgrade frontend to React 16
- Revisit webpack config resolve.symlinks=false
- Is dashboard-uaa-icon.jpg used externally or can it be removed? HOT 2
- "Remove User From Org" 500 error HOT 1
- In Windows, the font looks whacky at some sizes
- README should explain what Dashboard is & does HOT 2
- Migrate from glide to dep HOT 1
- Error when running the quick start HOT 4
- How to make this generic for everyone?
- How to deploy this UI in PWS HOT 9
- Error in deploying HOT 1
- Connection refused when deploying
- OrgManager of new org has no UI ability to create a space
- Show all spaces when there's more than one page
- Deleting a service with service keys attached shows success, but fails HOT 1
- move to CircleCI 2.0 HOT 1
- "Inviting users" 500 error HOT 1
- Remove snyk HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from cg-dashboard.