Comments (17)
Hmm.. my concern was that we will be able to see more part of the network if we show the network horizontally. Using a touchpad to scroll will feel the same horizontally and vertically. However using a mouse scroll wheel to scroll will feel weird.
But maybe after putting menus / other features in the future we will be left with the same amount of space both horizontally & vertically.
Ok. Let's go with vertical then. Are we removing the ability for zoom? Can we do keyboard shortcuts, and pinch to zoom gesture on the touchpad to scroll.
from fabrik.
@virajprabhu I am interested in working on the issue. How do I start?
from fabrik.
@souravsingh Great! Have you setup the code locally? Presently, you would notice that if you load a large network (Say GoogLenet from the examples), the size of each node of the jsPlumb flowchart is small and the flowchart extends horizontally. Scrolling the mousepad zooms the canvas and is the only way to visualize the entire flowchart, which isn't a good user experience.
What I'm proposing is:
– The default size of boxes in the flowchart should be larger
– The flowchart should extend vertically instead of horizontally
– Scroll to zoom should be disabled. Instead, the flowchart should be loaded in a scrollable div and a vertical scrollbar should be generated if the flowchart does not fit on the page.
This is a good example of what I'm proposing.
Does this make sense?
from fabrik.
@souravsingh Any update on this? Do you want to take this up?
from fabrik.
@virajprabhu I am interested in working on this issue.
from fabrik.
@souravsingh Great. Does my updated description in the comment above make sense to you? Let me know if you need any help getting started.
from fabrik.
@virajprabhu can I work on this?
from fabrik.
@jainamritanshu Sure. Let me know if you need help.
from fabrik.
@virajprabhu Sir I am having some confusion. I have successfully installed all the dependencies for the initial setup. Although I installed caffe as a docker image. The application will still not be able to import caffe modules in my local environment. Can you help me with this?
from fabrik.
@jainamritanshu Sure. Can you share whatever issues you are running into on the Gitter channel?
from fabrik.
@virajprabhu @dexter1691 I have made some changes to the front end to address these issues:
- fixed size of boxes
- flowchart extends vertically
- canvas scrolls instead of zoom
- added support for nice formatting of resnets in addition to the existing sequential networks and googlenet
- also addresses one issue from #16 where the buttons are now changed in appearance
Are these changes fine ?
from fabrik.
This looks great @utsavgarg, thanks! Can you share a screenshot of how the layer details on hover show up? In case you haven't seen this before, this is a neat implementation of the info boxes we could draw some ideas from. Apart from that, this is exactly what I had in mind, so please submit a PR. @dexter1691 @deshraj @abhshkdz may also have thoughts.
from fabrik.
@virajprabhu I have seen netscope before, but I haven't implemented that bit yet, the layer details are same as before, they pull up from the right side.
from fabrik.
I am unsure about the vertical part. most models are deep and not very wide while most screens are widescreen and are in landscape orientation. So to me, it makes more sense to display the model horizontally.
from fabrik.
But scrolling vertically is a lot more intuitive right? For any network that is deeper than what can fit in widescreen (which will be many, if we want to support ResNets!) I think vertical looks much nicer.
from fabrik.
@dexter1691 I have added back the ability to pan, and have added support for zoom in and out based on keyboard shortcuts and double clicks.
from fabrik.
Fixed in #67
from fabrik.
Related Issues (20)
- Feature Request: Add a new section in Model Zoo for Generation HOT 8
- Create documentation listing currently supported layers for Keras, Caffe and TensorFlow HOT 2
- Unable to export model
- "docker-compose up --build" throws DistributionNotFound error HOT 5
- Fabrik is built with DEBUG settings HOT 1
- Collaboration with GiraffeTools
- Improving security in shared links HOT 1
- networkId in caffe_app/consumers.py undefined when modifying parameters of layers HOT 1
- psycopg2 causes error while installing fabrik on ubuntu 18.04 HOT 4
- Trouble while installing, localhost doesn't show up in available sites while setting up GitHub authentication HOT 1
- Travis CI test for PRs fails by default. HOT 2
- [docs] Documentation headings unclear
- [Wiki] Fabrik Wiki outdated, mentions IDE instead of Fabrik.
- Upgrade from Python2.7 to Python3
- Broken links HOT 1
- Deprecation warning with some dependencies !! HOT 2
- Installation Faliure: No module named skimage.io HOT 4
- Need to add settings/dev.py as in order for migration to work (modified from the provided dev.sample.py)
- django.db.utils.OperationalError: could not translate host name "db" to address: Name or service not known
- Can‘t be deployed according to readme
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from fabrik.