import-vars and tools.namespace do not seem to be friends about potemkin HOT 4 CLOSED

A reproducing case would be great, thanks.

from potemkin.

Hey, thanks for the quick response. I'm digging into this a little more and it looks like I've got more of a heisenbug than I initially realized -- I'm now having trouble reproducing it myself.

I'll see if it turns up again; in the meantime sorry for raising the alarm prematurely =)

from potemkin.

No worries. All of these tools are different kinds of hacks, I wouldn't be surprised if there are lurking issues. Let me know if you find anything else.

from potemkin.

I came across this same issue I think you describe and I can reproduce it as follows.

say you have var
#'foo/bar

and you use import vars like this

(ns importer)

(import-vars
[foo bar])

then, in another ns you have
(ns consumer (:require [importer :refer :all]))

now in the result of (ns-refers 'consumer) you will see #'importer/bar but the :ns on the metadata of that var will be foo as expected. all ok so far.

now, with clojure.tools.namespace, when you have a compilation error, it calls clojure.tools.namespace.repl/recover-ns which walks over the ns-refers of your current ns and for each one calls (refer ns ...) , but the ns in question is found from the metadata, which is foo. the current ns already has bar from importer, and that is where it blows up.

from potemkin.