Giter Club home page Giter Club logo

Comments (4)

ztellman avatar ztellman commented on July 24, 2024

Hmmm. This appears to be due to how clojure.lang.RT/keys is defined:

static public ISeq keys(Object coll){
    return APersistentMap.KeySeq.create(seq(coll));
}

It takes all the entries, just to get at the keys. I can make the val lookup on each entry lazy, though, which I think is the semantically "right" way to give ourselves indirection. Thanks for pointing this out, I had completely missed this.

from potemkin.

savagematt avatar savagematt commented on July 24, 2024

No wonder I couldn't figure it out. I was looking at trunk, where I think keys might have changed implementation. Stared at that for the longest time. Thanks.

Are you saying that the MapEntrys that come back from seq and entryAt should overload val and getValue to lazily call valAt?

from potemkin.

ztellman avatar ztellman commented on July 24, 2024

Yeah, that was my thought.

On Thu, Jul 10, 2014 at 12:38 PM, savagematt [email protected]
wrote:

No wonder I couldn't figure it out. I was looking at trunk, where I think
keys might have changed implementation. Stared at that for the longest
time. Thanks.

Are you saying that the MapEntrys that come back from seq and entryAt
should overload val and getValue to lazily call valAt?


Reply to this email directly or view it on GitHub
#23 (comment).

from potemkin.

ztellman avatar ztellman commented on July 24, 2024

Merged, sorry for the delay.

from potemkin.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.